Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy_to_user instead of put_user.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Matt Mackall

Subject: Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy_to_user instead of put_user.

Date: Thursday, June 5, 2008 - 12:06 pm

On Thu, 2008-06-05 at 12:02 -0700, Andrew Morton wrote:
quoted text> On Thu, 5 Jun 2008 11:04:21 -0400
> "Thomas Tuttle" <ttuttle@google.com> wrote:
> 
> > While fiddling with pagemap, I discovered a bug in add_to_pagemap.
> 
> so...  afaict we have some fairly significant problems in here and a
> version 2 of the patchset is in order?
> 
> If so, when preparing that patchset please do have a think about which
> of the fixes you believe should be backported into 2.6.25.x and prepare
> the patches so that those fixes come first, to ease that backporting.

For 2.6.25.x, we should probably just add a cast to the put_user dest.
Thomas?

-- 
Mathematics is the supreme nostalgia of our time.

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/5] pagemap: Modify add_to_pagemap to use copy_to_ ..., Thomas Tuttle, (Thu Jun 5, 8:04 am)

Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy ..., Matt Mackall, (Thu Jun 5, 8:57 am)

Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy ..., Thomas Tuttle, (Thu Jun 5, 9:01 am)

Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy ..., Matt Mackall, (Thu Jun 5, 9:20 am)

Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy ..., Andrew Morton, (Thu Jun 5, 12:02 pm)

Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy ..., Matt Mackall, (Thu Jun 5, 12:06 pm)

Re: [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy ..., Thomas Tuttle, (Thu Jun 5, 12:09 pm)


linux-kernel:
Ken Chen	[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Ingo Molnar	Re: [PATCH v3] x86: merge the simple bitops and move them to bitops.h
Jan Engelhardt	Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection
Dmitry Torokhov	Re: [2.6 patch] input/serio/hp_sdc.c section fix
Rafael J. Wysocki	[Bug #16380] Loop devices act strangely in 2.6.35
git:
Steven Grimm	Using git as a general backup mechanism (was Re: Using GIT to store /etc)
Jeff King	Re: [PATCH] git-reset: allow --soft in a bare repo
Johannes Sixt	Re: [PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c
Johannes Schindelin	Re: [PATCH] Uninstall rule for top level Makefile
Shawn O. Pearce	Re: [PATCH v2] Speed up bash completion loading
git-commits-head:
Linux Kernel Mailing List	cgroups: clean up cgroup_pidlist_find() a bit
Linux Kernel Mailing List	sony-laptop: Add support for extended hotkeys
Linux Kernel Mailing List	IB/core: Add support for masked atomic operations
Linux Kernel Mailing List	V4L/DVB (8939): cx18: fix sparse warnings
Linux Kernel Mailing List	ipv6 mcast: Check address family of gf_group in getsockopt(MS_FILTER).
linux-netdev:
Inaky Perez-Gonzalez	[PATCH 40/40] wimax/i2400m: add CREDITS and MAINTAINERS entries
Karsten Keil	[mISDN PATCH v2 05/19] Reduce stack size in dsp_cmx_send()
linux	Re: 2.6.23-rc8 network problem. Mem leak? ip1000a?
David Miller	Re: tun: Use netif_receive_skb instead of netif_rx
David Miller	Re: [net-next PATCH v2] llc enhancements
freebsd-current:
Matthew Fleming	Re: [RFC] Outline of USB process integration in the kernel taskqueue system
illoai@gmail.com	Re: OT: 2d password
Hartmut Brandt	Re: problem with nss_ldap
Andrew Reilly	Re: FreeBSD's problems as seen by the BSDForen.de community
Max Laier	Re: Upcoming ABI Breakage in RELENG_7