Subject: [PATCH] Adding dummy release functions to avoid warnings.
From: Vitaliy Ivanov <vitalivanov@gmail.com>
Trivial fix for #9690.
Added simple release functions that doing nothing.
Not sure whether we can leave it as is or to rework using platform_device helpers like platform_device_alloc.
This approach is used in many drivers.
Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com>
--
drivers/mtd/maps/physmap.c | 6 ++++++
drivers/video/hgafb.c | 10 +++++++++-
2 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
index bc4649a..5bdbd04 100644
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -264,11 +264,17 @@ static struct resource physmap_flash_resource = {
.flags = IORESOURCE_MEM,
};
+/* Fake release func.*/
+static void physmap_flash_release(struct device *dev)
+{
+}
+
static struct platform_device physmap_flash = {
.name = "physmap-flash",
.id = 0,
.dev = {
.platform_data = &physmap_flash_data,
+ .release = physmap_flash_release,
},
.num_resources = 1,
.resource = &physmap_flash_resource,
diff --git a/drivers/video/hgafb.c b/drivers/video/hgafb.c
index fb9e672..8707115 100644
--- a/drivers/video/hgafb.c
+++ b/drivers/video/hgafb.c
@@ -623,8 +623,16 @@ static struct device_driver hgafb_driver = {
.remove = hgafb_remove,
};
+/* Fake release func.*/
+static void hgafb_device_release(struct device *dev)
+{
+}
+
static struct platform_device hgafb_device = {
- .name = "hgafb",
+ .name = "hgafb",
+ .dev = {
+ .release = hgafb_device_release,
+ },
};
static int __init hgafb_init(void)
--
Hi all, Natalie reported that patch wasn't accepted. Please check this out. If I need to correct it somehow then pls let me know. V. ---------- Forwarded message ---------- From: Vitaliy Ivanov <vitalivanov@gmail.com> Date: Wed, Apr 16, 2008 at 3:34 AM Subject: [PATCH] Adding dummy release functions to avoid warnings. To: linux-kernel@vger.kernel.org, devzero@web.de, jsun@junsun.net, dwmw2@infradead.org Subject: [PATCH] Adding dummy release functions to avoid warnings. From: Vitaliy Ivanov <vitalivanov@gmail.com> Trivial fix for #9690. Added simple release functions that doing nothing. Not sure whether we can leave it as is or to rework using platform_device helpers like platform_device_alloc. This approach is used in many drivers. Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com> -- drivers/mtd/maps/physmap.c | 6 ++++++ drivers/video/hgafb.c | 10 +++++++++- 2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c index bc4649a..5bdbd04 100644 --- a/drivers/mtd/maps/physmap.c +++ b/drivers/mtd/maps/physmap.c @@ -264,11 +264,17 @@ static struct resource physmap_flash_resource = { .flags = IORESOURCE_MEM, }; +/* Fake release func.*/ +static void physmap_flash_release(struct device *dev) +{ +} + static struct platform_device physmap_flash = { .name = "physmap-flash", .id = 0, .dev = { .platform_data = &physmap_flash_data, + .release = physmap_flash_release, }, .num_resources = 1, .resource = &physmap_flash_resource, diff --git a/drivers/video/hgafb.c b/drivers/video/hgafb.c index fb9e672..8707115 100644 --- a/drivers/video/hgafb.c +++ b/drivers/video/hgafb.c @@ -623,8 +623,16 @@ static struct device_driver hgafb_driver = { .remove = hgafb_remove, }; +/* Fake release func.*/ +static void ...
Please see Documentation/kobject.txt - search for the text I expect that hgafb-convert-to-new-platform-driver-api-bugzilla-9689.patch which I merged yesterday will help here. --
Do not taunt Happy Fun Dave. -- dwmw2 --
Andrew, Damn. I knew that everything is not so easy here;) Got it. Tnx. But in such case there are _again_ many drivers that do implement such fake functions. Again is because when I tried to port some usb driver there were issues with locking that was not correct but many drivers worked exactly this incorrect way. Anyway, tnx for clarifying this. V. --
