login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
June
»
5
Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading in multiples of 8
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Matt Mackall
Subject:
Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading in multiples of 8
Date: Thursday, June 5, 2008 - 9:21 am
On Thu, 2008-06-05 at 12:14 -0400, Thomas Tuttle wrote:
quoted text
> On Thu, Jun 5, 2008 at 12:09 PM, Matt Mackall <mpm@selenic.com> wrote: > > Yes, I got that, I'm just mathematically impaired this morning. Read > > that as "when someone tries to do a *20* byte read, do a 16-byte read.." > > In other words, round down to the nearest multiple of 8. > > Oh. I would seriously question doing that, because it would allow > reads that are improperly split up to fail silently. What happens if > someone tries to read 40 bytes, and (for some reason) it gets split > into two 20-byte reads? Instead of "12345" they'll get "12.34." > (where . is 4 zero or garbage bytes). I'd rather they get an error.
I suppose you're right, people usually don't check those return codes. -- Mathematics is the supreme nostalgia of our time. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH 3/5] pagemap: Make pagemap_read enforce reading in ...
, Thomas Tuttle
, (Thu Jun 5, 8:06 am)
Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading ...
, Matt Mackall
, (Thu Jun 5, 9:03 am)
Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading ...
, Thomas Tuttle
, (Thu Jun 5, 9:05 am)
Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading ...
, Matt Mackall
, (Thu Jun 5, 9:09 am)
Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading ...
, Thomas Tuttle
, (Thu Jun 5, 9:14 am)
Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading ...
, Matt Mackall
, (Thu Jun 5, 9:21 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Frederic Weisbecker
[PATCH v2] struct sort_entry has a callback named snprintf that turns an entry int...
FUJITA Tomonori
Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Jens Axboe
Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bo...
Andrew Morton
Re: [PATCH v3 0/4] Introduce hardware spinlock framework
Ingo Molnar
Re: [GIT PULL] time.c - respin
git
:
Junio C Hamano
Re: git-svnimport
Michal Sojka
[PATCHv5 1/2] filter-branch: Fix to allow replacing submodules with another content
Junio C Hamano
Re: Fwd: git status options feature suggestion
Johannes Schindelin
Re: [PATCH] Fix approxidate("never") to always return 0
A Large Angry SCM
Re: [RFC] origin link for cherry-pick and revert
linux-netdev
:
Arnaldo Carvalho de Melo
Re: [PATCH 06/37] dccp: Limit feature negotiation to connection setup phase
Gerrit Renker
[PATCH 1/5] dccp: Initialisation framework for feature negotiation
Ursula Braun
[patch 2/8] [PATCH] af_iucv: sync sk shutdown flag if iucv path is quiesced
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
git-commits-head
:
Linux Kernel Mailing List
ARM: S3C64XX: DMA: Callback with correct buffer pointer
Linux Kernel Mailing List
sata_mv: drop unncessary EH callback resetting
Linux Kernel Mailing List
timer: Try to survive timer callback preempt_count leak
Linux Kernel Mailing List
powerpc/kexec: Add support for FSL-BookE
Linux Kernel Mailing List
ARM: 5670/1: bcmring: add default configuration for bcmring arch
openbsd-misc
:
Rene Maroufi
smtpd: Aliases only work with for local alias aliases
Stephen J. Bevan
GRE over IPsec
Christophe Rioux
Implementation example of snmp
Darrin Chandler
Re: strange output on openbsd C code
Nick Holland
Re: booting openbsd on eee without cd-rom
Colocation donated by:
Syndicate