Re: Kernel marker has no performance impact on ia64.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Masami Hiramatsu
Date: Thursday, June 5, 2008 - 7:28 am

Hi Peter and Mathieu,

Peter Zijlstra wrote:

If so, I'd like to suggest below changes,

- introduce below macro in marker.h

#define DEFINE_TRACE(name, vargs, args...)	\
static inline void trace_##name vargs		\
{						\
	trace_mark(name, #vargs, ##args);	\
}

- remove __marker_check_format from __trace_mark
- and write a definition in sched_trace.h

DEFINE_TRACE(sched_switch, (struct task_struct *prev, struct task_struct *next),
	     prev, next);

Thus, we can remove fmt string and also ensure the type checking, because;
- Type checking at the trace point is done by the compiler.
- Type checking of probe handler can be done by comparing #vargs strings.

Thanks,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Kernel marker has no performance impact on ia64., Hideo AOKI, (Mon Jun 2, 3:12 pm)
Re: Kernel marker has no performance impact on ia64., Peter Zijlstra, (Mon Jun 2, 3:32 pm)
Re: Kernel marker has no performance impact on ia64., Mathieu Desnoyers, (Mon Jun 2, 4:21 pm)
RE: Kernel marker has no performance impact on ia64., Takashi Nishiie, (Mon Jun 2, 11:07 pm)
Re: Kernel marker has no performance impact on ia64., Masami Hiramatsu, (Tue Jun 3, 9:58 pm)
Re: Kernel marker has no performance impact on ia64., Peter Zijlstra, (Wed Jun 4, 3:27 pm)
Re: Kernel marker has no performance impact on ia64., Mathieu Desnoyers, (Wed Jun 4, 4:22 pm)
Re: Kernel marker has no performance impact on ia64., Mathieu Desnoyers, (Wed Jun 4, 4:26 pm)
Re: Kernel marker has no performance impact on ia64., Masami Hiramatsu, (Wed Jun 4, 4:40 pm)
Re: Kernel marker has no performance impact on ia64., Peter Zijlstra, (Thu Jun 5, 1:12 am)
Re: Kernel marker has no performance impact on ia64., Masami Hiramatsu, (Thu Jun 5, 7:28 am)
Re: Kernel marker has no performance impact on ia64., Mathieu Desnoyers, (Thu Jun 12, 6:53 am)
Re: Kernel marker has no performance impact on ia64., Mathieu Desnoyers, (Thu Jun 12, 7:04 am)
Re: Kernel marker has no performance impact on ia64., Peter Zijlstra, (Thu Jun 12, 7:27 am)
Re: Kernel marker has no performance impact on ia64., Masami Hiramatsu, (Thu Jun 12, 8:31 am)
Re: Kernel marker has no performance impact on ia64., Frank Ch. Eigler, (Thu Jun 12, 8:53 am)
Re: Kernel marker has no performance impact on ia64., Masami Hiramatsu, (Thu Jun 12, 9:16 am)
Re: Kernel marker has no performance impact on ia64., Frank Ch. Eigler, (Thu Jun 12, 9:43 am)
Re: Kernel marker has no performance impact on ia64., Peter Zijlstra, (Thu Jun 12, 9:53 am)
Re: Kernel marker has no performance impact on ia64., Peter Zijlstra, (Thu Jun 12, 9:56 am)
Re: Kernel marker has no performance impact on ia64., Masami Hiramatsu, (Thu Jun 12, 10:05 am)
Re: Kernel marker has no performance impact on ia64., Frank Ch. Eigler, (Thu Jun 12, 10:38 am)
Re: Kernel marker has no performance impact on ia64., Frank Ch. Eigler, (Thu Jun 12, 10:48 am)
Re: Kernel marker has no performance impact on ia64., Masami Hiramatsu, (Thu Jun 12, 12:34 pm)
Re: Kernel marker has no performance impact on ia64., Mathieu Desnoyers, (Thu Jun 12, 3:10 pm)
RE: Kernel marker has no performance impact on ia64., Takashi Nishiie, (Thu Jun 12, 9:19 pm)
Re: Kernel marker has no performance impact on ia64., Peter Zijlstra, (Fri Jun 13, 4:01 am)
Re: Kernel marker has no performance impact on ia64., Frank Ch. Eigler, (Fri Jun 13, 7:17 am)
Re: Kernel marker has no performance impact on ia64., Masami Hiramatsu, (Fri Jun 13, 11:02 am)
RE: Kernel marker has no performance impact on ia64., Takashi Nishiie, (Sun Jun 15, 7:58 pm)