Re: [PATCH] kbuild: simplify module versioning procedure

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Sam Ravnborg
Date: Thursday, June 5, 2008 - 5:17 am

Hi Peter.

On Mon, Jun 02, 2008 at 06:31:14PM +0200, Peter Oberparleiter wrote:
It looks like a simplification but there is actually a reason why
it is done with a temporary fil in this way.

Consider a kernel build that is being terminated with ctrl-c
in the middle. If we when ctrl-c are hit are doing the final 
steps of genksyms then we will next time we type make
consider all done and we will not redo the modversioning
part of the rule because we have an updated .o file.

We have this issue in other places in the build system but
I have not audited the use of redirects yet.

But applying your patch would introduce yet another place where we
have such an issue and we want to get rid of the spots
where hitting ctrl-c can leave us with an inconsistent build.

So I will not apply this patch.

	Sam
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] kbuild: simplify module versioning procedure, Peter Oberparleiter, (Mon Jun 2, 9:31 am)
Re: [PATCH] kbuild: simplify module versioning procedure, Sam Ravnborg, (Thu Jun 5, 5:17 am)