Re: Linux 2.6.26-rc5 (G5 SATA broken)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Olaf Hering <olaf@...>
Cc: Alan Cox <alan@...>, Jeff Garzik <jeff@...>, Linus Torvalds <torvalds@...>, <linuxppc-dev@...>, Linux Kernel Mailing List <linux-kernel@...>
Date: Thursday, June 5, 2008 - 8:09 am

On Thu, 5 Jun 2008, Olaf Hering wrote:

I've been bisecting that on Quad G5 (sata_svw): irq 18: nobody cared ...,
then later endless ata1.00: exception..., blah blah, ata1: EH complete.
It comes down to:

commit a57c1bade5a0ee5cd8b74502db9cbebb7f5780b2
Author: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date:   Thu May 29 22:10:58 2008 +0100
libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl

And the patch I'm finding successful is below: I won't sign it off,
for all I know it's reverting part of what Alan is trying to achieve;
but I expect it'll help towards the right fix.

Hugh

--- 2.6.26-rc5/drivers/ata/libata-sff.c	2008-06-05 07:18:07.000000000 +0100
+++ linux/drivers/ata/libata-sff.c	2008-06-05 12:42:39.000000000 +0100
@@ -278,7 +278,7 @@ static u8 ata_sff_irq_status(struct ata_
 		    	return status;
 	}
 	/* Clear INTRQ latch */
-	status = ata_sff_check_status(ap);
+	status = ap->ops->sff_check_status(ap);
 	return status;
 }
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.26-rc5, Linus Torvalds, (Wed Jun 4, 11:36 pm)
Re: Linux 2.6.26-rc5, Jesper Krogh, (Sat Jun 7, 3:52 pm)
Re: Linux 2.6.26-rc5, Jesper Krogh, (Sat Jun 7, 3:44 pm)
Re: Linux 2.6.26-rc5, Frans Pop, (Sat Jun 7, 5:50 pm)
Re: Linux 2.6.26-rc5, Bjorn Helgaas, (Sun Jun 8, 11:39 pm)
Re: Linux 2.6.26-rc5, Frans Pop, (Mon Jun 9, 6:01 am)
Re: Linux 2.6.26-rc5, Alex Romosan, (Thu Jun 5, 10:47 am)
Re: Linux 2.6.26-rc5, Ben Dooks, (Thu Jun 5, 10:43 am)
Re: Linux 2.6.26-rc5, Linus Torvalds, (Fri Jun 6, 2:35 pm)
ACPI pull for 2.6.26?, Adrian Bunk, (Tue Jun 10, 8:57 am)
Re: ACPI pull for 2.6.26?, Len Brown, (Tue Jun 10, 11:23 am)
Re: ACPI pull for 2.6.26?, Adrian Bunk, (Tue Jun 10, 11:39 am)
Re: Linux 2.6.26-rc5, Alejandro Riveira , (Thu Jun 5, 9:03 am)
Re: Linux 2.6.26-rc5, Linus Torvalds, (Thu Jun 5, 10:54 am)
Re: Linux 2.6.26-rc5, Bjorn Helgaas, (Thu Jun 5, 12:12 pm)
Re: Linux 2.6.26-rc5, Linus Torvalds, (Thu Jun 5, 12:19 pm)
Re: Linux 2.6.26-rc5, Bjorn Helgaas, (Thu Jun 5, 12:32 pm)
Re: Linux 2.6.26-rc5, Bjorn Helgaas, (Thu Jun 5, 11:12 am)
Re: Linux 2.6.26-rc5, Olaf Hering, (Thu Jun 5, 7:24 am)
Re: Linux 2.6.26-rc5, Alan Cox, (Thu Jun 5, 8:42 am)
Re: Linux 2.6.26-rc5 (G5 SATA broken), Hugh Dickins, (Thu Jun 5, 8:09 am)
Re: Linux 2.6.26-rc5 (G5 SATA broken), Benjamin Herrenschmidt, (Fri Jun 6, 12:36 am)
Re: Linux 2.6.26-rc5 (G5 SATA broken), Alan Cox, (Thu Jun 5, 8:54 am)
[PATCH] libata: fix G5 SATA broken on -rc5, Hugh Dickins, (Thu Jun 5, 9:44 am)
Re: [PATCH] libata: fix G5 SATA broken on -rc5, Olaf Hering, (Thu Jun 5, 10:45 am)