Re: [PATCH -mm 11/14] bootmem: respect goal more likely

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Johannes Weiner <hannes@...>
Cc: Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>, Yinghai Lu <yhlu.kernel@...>, Andi Kleen <andi@...>, <linux-kernel@...>
Date: Thursday, June 5, 2008 - 4:31 am

I gotcha!  :-)

 	max -= PFN_DOWN(bdata->node_boot_start);
 	start -= PFN_DOWN(bdata->node_boot_start);
+	fallback -= PFN_DOWN(bdata->node_boot_start);
 
 	if (bdata->last_success > start) {
-		/* Set goal here to trigger a retry on failure */
-		start = goal = ALIGN(bdata->last_success, step);
+		fallback = start; -------------------------------- (*)
+		start = ALIGN(bdata->last_success, step);
 	}

(*) is root cause. "fallback" is set as 0, because start is index of bitmap
at here. When normal zone is allocated first, and DMA zone is required by
alloc_bootmem_low() later and first page is free yet, fallback is set as 0.

+	if (fallback) {
+		start = ALIGN(fallback, step);
+		fallback = 0;
+		goto find_block;
+	}
+

As a result, this retry code is skipped, and alloc_bootmem_low() fails. 
So, when I change here from fallback to a retry_flag, my box can boot up.

Thanks.
-- 
Yasunori Goto 


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH -mm 11/14] bootmem: respect goal more likely, Johannes Weiner, (Mon Jun 2, 8:50 pm)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Yasunori Goto, (Tue Jun 3, 9:59 am)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Johannes Weiner, (Tue Jun 3, 12:16 pm)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Yasunori Goto, (Wed Jun 4, 6:55 am)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Johannes Weiner, (Wed Jun 4, 4:25 pm)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Yasunori Goto, (Wed Jun 4, 10:58 pm)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Johannes Weiner, (Thu Jun 5, 12:13 am)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Yasunori Goto, (Thu Jun 5, 4:31 am)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Johannes Weiner, (Thu Jun 5, 12:41 pm)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Yasunori Goto, (Thu Jun 5, 8:25 pm)