Re: [PATCH -mm 11/14] bootmem: respect goal more likely

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Yasunori Goto <y-goto@...>
Cc: Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>, Yinghai Lu <yhlu.kernel@...>, Andi Kleen <andi@...>, <linux-kernel@...>
Date: Thursday, June 5, 2008 - 12:13 am

Hi,

Yasunori Goto <y-goto@jp.fujitsu.com> writes:


Okay.


Thanks!


Sorry, my fault.

How about last_offset -> last_end_off to reflect that it is the offset
of the last allocations end?

And last_succes -> hint_idx to reflect that it is an index we start
searching from but it is not strict and we fall back if we find nothing
starting from there.  Also free_bootmem* sets it as a hint from where we
could start searching.

I also would set last_success/hint_idx to the _end_ of the successful
allocation (instead of the beginning of it) in alloc_bootmem_core
because we do not want to search for a new free block from the beginning
of the last allocation but rather right after it.

What do you think?

	Hannes
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH -mm 11/14] bootmem: respect goal more likely, Johannes Weiner, (Mon Jun 2, 8:50 pm)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Yasunori Goto, (Tue Jun 3, 9:59 am)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Johannes Weiner, (Tue Jun 3, 12:16 pm)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Yasunori Goto, (Wed Jun 4, 6:55 am)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Johannes Weiner, (Wed Jun 4, 4:25 pm)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Yasunori Goto, (Wed Jun 4, 10:58 pm)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Johannes Weiner, (Thu Jun 5, 12:13 am)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Yasunori Goto, (Thu Jun 5, 4:31 am)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Johannes Weiner, (Thu Jun 5, 12:41 pm)
Re: [PATCH -mm 11/14] bootmem: respect goal more likely, Yasunori Goto, (Thu Jun 5, 8:25 pm)