> Hi Eric,
>
> On Wed, 04 Jun 2008 21:24:37 +0200, Éric Piel wrote:
>> We haven't received any review for this driver since last week's post by
>> Yan :-( That's why I'm adding explicitly as receivers of this email all
>> the people who have reviewed the first two previous takes. Apologies for
>> the possible multiple receptions.
>>
>> It would be _really really kind_ if some of you could take some time and
>> comment (or simply ACK ;-) ) this code. It adds support for hardware
>> which can be found in mostly every HP Compaq laptop less than three
>> years old. It's quite worthy.
>>
>> Mark, as maintainer of the hwmon tree, would accept this driver? Let us
>> know if there are things we need to change.
>
> If you didn't receive any answer, my guess is that it's because you're
> trying to add this driver to the wrong tree. Why would this driver go
> in drivers/hwmon and be reviewed by hwmon folks, when it doesn't expose
> a single hwmon attribute to user-space?
>
> I guess you thought putting the driver there would be fine because
> that's where the hdaps and ams drivers are, but IMHO the hdaps and ams
> drivers should never have been placed in drivers/hwmon. These devices
> really aren't hardware monitoring chips is the traditional sense of the
> term. They are different chips, serving different purposes and
> deserving a totally different interface. They'd better live in a
> different subsystem and be maintainer by a different crew with interest
> in these devices and hardware to test the drivers.
>
> This discussion thread might sched some light on a possible approach:
>
http://marc.info/?l=lm-sensors&m=121127824726050&w=2
>
> So my advice is that you don't wait for a review from the hwmon people,
> because apparently we don't have much interest in this type of device,
> so you'll be waiting forever. You're much better adding the mdps driver
> to drivers/misc through Andrew Morton, at least until someone takes
> care of creating a subsystem for this type of devices and move all
> existing drivers there.
