Home » Mailing list archives » linux-kernel » 2008 » June » 4

[PATCH 1/3] ext2: don't inherit inappropriate inode flags from parent

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Duane Griffin
Subject: [PATCH 1/3] ext2: don't inherit inappropriate inode flags from parent
Date: Wednesday, June 4, 2008 - 5:46 am

At present BTREE is the only flag that new ext2 inodes do NOT inherit from
their parent. In addition prevent the flags DIRTY, ECOMPR, INDEX, IMAGIC
and TOPDIR from being inherited.

Signed-off-by: Duane Griffin <duaneg@dghda.com>

diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index f597413..a51d4ca 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -565,7 +565,7 @@ got:
 	inode->i_blocks = 0;
 	inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC;
 	memset(ei->i_data, 0, sizeof(ei->i_data));
-	ei->i_flags = EXT2_I(dir)->i_flags & ~EXT2_BTREE_FL;
+	ei->i_flags = EXT2_I(dir)->i_flags & EXT2_FL_INHERITED;
 	if (S_ISLNK(mode))
 		ei->i_flags &= ~(EXT2_IMMUTABLE_FL|EXT2_APPEND_FL);
 	/* dirsync is only applied to directories */
diff --git a/include/linux/ext2_fs.h b/include/linux/ext2_fs.h
index 84cec2a..6c87c8e 100644
--- a/include/linux/ext2_fs.h
+++ b/include/linux/ext2_fs.h
@@ -194,6 +194,10 @@ struct ext2_group_desc
 #define EXT2_FL_USER_VISIBLE		FS_FL_USER_VISIBLE	/* User visible flags */
 #define EXT2_FL_USER_MODIFIABLE		FS_FL_USER_MODIFIABLE	/* User modifiable flags */
 
+/* Flags that should be inherited by new inodes from their parent. */
+#define EXT2_FL_INHERITED ~(EXT2_DIRTY_FL | EXT2_ECOMPR_FL | EXT2_BTREE_FL |\
+			    EXT2_INDEX_FL | EXT2_IMAGIC_FL | EXT2_TOPDIR_FL)
+
 /*
  * ioctl commands
  */
-- 
1.5.3.7

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/3] ext{2,3,4}: don't inherit inappropriate inode ..., Duane Griffin, (Wed Jun 4, 5:46 am)
[PATCH 1/3] ext2: don't inherit inappropriate inode flags ..., Duane Griffin, (Wed Jun 4, 5:46 am)
[PATCH 2/3] ext3: don't inherit inappropriate inode flags ..., Duane Griffin, (Wed Jun 4, 5:46 am)
[PATCH 3/3] ext4: don't inherit inappropriate inode flags ..., Duane Griffin, (Wed Jun 4, 5:46 am)