On Wed, 4 Jun 2008 09:31:50 +0200
"Andrew Victor" <avictor.za@gmail.com> wrote:

quoted text
> hi Andrew,
> 
> >> +             return 0;
> >
> > That looks like the wrong return value?
> 
> Since the watchdog registers are Write-Once, if the user does not
> specify a "wdt_timeout" parameter we'd still like the driver to load
> even if it's not enabled.

Surely you can avoid doing the register writes until after you check the
validity of arguments ?
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/