Home » Mailing list archives » linux-kernel » 2008 » June » 4

Re: [PATCH 1/5] jbd: strictly check for write errors on data buffers

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jan Kara <jack@...>
To: Andrew Morton <akpm@...>
Cc: Hidehiro Kawai <hidehiro.kawai.ez@...>, <sct@...>, <adilger@...>, <linux-kernel@...>, <linux-ext4@...>, <jack@...>, <jbacik@...>, <cmm@...>, <tytso@...>, <yumiko.sugita.yf@...>, <satoshi.oshima.fk@...>
Subject: Re: [PATCH 1/5] jbd: strictly check for write errors on data buffers
Date: Wednesday, June 4, 2008 - 6:19 am

On Tue 03-06-08 15:30:50, Andrew Morton wrote:
  I see two reasons:
1) If fs below us is returning IO errors, we don't really know how severe
it is so it's safest to stop accepting writes. Also user notices the
problem early this way. I agree that with the growing size of disks and
thus probability of seeing IO error, we should probably think of something
cleverer than this but aborting seems better than just doing nothing.

2) If the IO error is just transient (i.e., link to NAS is disconnected for
a while), we would silently break ordering mode guarantees (user could be
able to see old / uninitialized data).

								Honza

PS: Changed Andreas's address in the email to the new one...
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/5] jbd: possible filesystem corruption fixes (take 2), Hidehiro Kawai, (Mon Jun 2, 6:40 am)
Re: [PATCH 0/5] jbd: possible filesystem corruption fixes (t..., Jan Kara, (Mon Jun 2, 8:05 am)
Re: [PATCH 0/5] jbd: possible filesystem corruption fixes (t..., Hidehiro Kawai, (Tue Jun 3, 12:30 am)
[PATCH 5/5] ext3: abort ext3 if the journal has aborted, Hidehiro Kawai, (Mon Jun 2, 6:48 am)
Re: [PATCH 5/5] ext3: abort ext3 if the journal has aborted, Jan Kara, (Mon Jun 2, 8:49 am)
[PATCH 4/5] jbd: fix error handling for checkpoint io, Hidehiro Kawai, (Mon Jun 2, 6:47 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Jan Kara, (Mon Jun 2, 8:44 am)
[PATCH 4/5] jbd: fix error handling for checkpoint io, Hidehiro Kawai, (Tue Jun 3, 12:40 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Jan Kara, (Tue Jun 3, 4:02 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Hidehiro Kawai, (Mon Jun 23, 7:14 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Jan Kara, (Mon Jun 23, 8:22 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Hidehiro Kawai, (Tue Jun 24, 7:52 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Jan Kara, (Tue Jun 24, 9:33 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Hidehiro Kawai, (Fri Jun 27, 4:06 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Jan Kara, (Fri Jun 27, 6:24 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Hidehiro Kawai, (Mon Jun 30, 1:09 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Jan Kara, (Mon Jul 7, 6:07 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Hidehiro Kawai, (Tue Jun 3, 1:11 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Andrew Morton, (Tue Jun 3, 1:20 am)
Re: [PATCH 4/5] jbd: fix error handling for checkpoint io, Hidehiro Kawai, (Tue Jun 3, 12:31 am)
[PATCH 3/5] jbd: abort when failed to log metadata buffers, Hidehiro Kawai, (Mon Jun 2, 6:46 am)
Re: [PATCH 3/5] jbd: abort when failed to log metadata buffers, Andrew Morton, (Tue Jun 3, 6:35 pm)
Re: [PATCH 3/5] jbd: abort when failed to log metadata buffers, Hidehiro Kawai, (Wed Jun 4, 6:57 am)
Re: [PATCH 3/5] jbd: abort when failed to log metadata buffers, Jan Kara, (Mon Jun 2, 8:00 am)
[PATCH 2/5] jbd: ordered data integrity fix, Hidehiro Kawai, (Mon Jun 2, 6:45 am)
Re: [PATCH 2/5] jbd: ordered data integrity fix, Andrew Morton, (Tue Jun 3, 6:33 pm)
Re: [PATCH 2/5] jbd: ordered data integrity fix, Hidehiro Kawai, (Wed Jun 4, 6:55 am)
Re: [PATCH 2/5] jbd: ordered data integrity fix, Jan Kara, (Mon Jun 2, 7:59 am)
[PATCH 1/5] jbd: strictly check for write errors on data buf..., Hidehiro Kawai, (Mon Jun 2, 6:43 am)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Andrew Morton, (Tue Jun 3, 6:30 pm)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Hidehiro Kawai, (Wed Jun 4, 6:53 am)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Jan Kara, (Wed Jun 4, 6:19 am)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Andrew Morton, (Wed Jun 4, 2:19 pm)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Andreas Dilger, (Wed Jun 4, 5:58 pm)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Theodore Tso, (Wed Jun 4, 5:22 pm)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Mike Snitzer, (Wed Jun 4, 11:28 pm)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Andrew Morton, (Wed Jun 4, 5:58 pm)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Theodore Tso, (Wed Jun 4, 6:51 pm)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Jan Kara, (Thu Jun 5, 5:35 am)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Hidehiro Kawai, (Thu Jun 5, 7:33 am)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Theodore Tso, (Thu Jun 5, 10:29 am)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Andrew Morton, (Thu Jun 5, 12:20 pm)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Andreas Dilger, (Thu Jun 5, 2:49 pm)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Hidehiro Kawai, (Mon Jun 9, 6:09 am)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Jan Kara, (Wed Jun 11, 8:35 am)
Re: [PATCH 1/5] jbd: strictly check for write errors on data..., Hidehiro Kawai, (Thu Jun 12, 9:19 am)