Re: [PATCH] USB: fix interrupt disabling for HCDs with shared interrupt handlers | KernelTrap

Re: [PATCH] USB: fix interrupt disabling for HCDs with shared interrupt handlers

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Alan Stern <stern@...>

To: Stefan Becker <Stefan.Becker@...>

Cc: David Brownell <david-b@...>, <linux-kernel@...>, <linux-usb@...>, ext Linus Torvalds <torvalds@...>

Subject: Re: [PATCH] USB: fix interrupt disabling for HCDs with shared interrupt handlers

Date: Monday, June 30, 2008 - 3:35 pm

On Mon, 30 Jun 2008, Stefan Becker wrote:

quoted text> Hi,
> 
> here is the proposed patch to fix the problem. I hope I used git 
> correctly to generate it...

quoted text> This patch doesn't modify the interface of usb_add_hcd(), i.e. HCD code
> can still use IRQF_DISABLED. It will now silently convert this into an
> internal HCD flag and clear IRQF_DISABLED before requesting the interrupt
> from the Linux core. usb_hcd_irq() will check this flag to disable/re-enable
> the interrupts on a case by case basis.

Don't bother with this extra stuff.  All USB host controller drivers
want to have interrupts disabled when their IRQ handlers run.

Alan Stern

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[REGRESSION] 2.6.24/25: random lockups when accessing extern..., Stefan Becker, (Sun Jun 22, 12:55 pm)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Rene Herman, (Sun Jun 22, 1:42 pm)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Alan Stern, (Sun Jun 22, 3:31 pm)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Stefan Becker, (Mon Jun 23, 11:52 am)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Alan Stern, (Mon Jun 23, 2:10 pm)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Stefan Becker, (Tue Jun 24, 2:41 pm)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Alan Stern, (Tue Jun 24, 5:15 pm)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Stefan Becker, (Wed Jun 25, 11:52 am)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Alan Stern, (Wed Jun 25, 2:38 pm)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Stefan Becker, (Thu Jun 26, 2:31 am)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Alan Stern, (Thu Jun 26, 10:25 am)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Stefan Becker, (Thu Jun 26, 6:07 pm)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Alan Stern, (Fri Jun 27, 12:10 pm)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Stefan Becker, (Sat Jun 28, 11:39 am)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Alan Stern, (Sat Jun 28, 12:53 pm)

BUG in 2.6.26-rc8 interrupt handling, Becker Stefan (Nokia-D/Salo)..., (Sat Jun 28, 3:34 pm)

Re: BUG in 2.6.26-rc8 interrupt handling, David Brownell, (Sat Jun 28, 3:51 pm)

PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts, Stefan Becker, (Sun Jun 29, 10:57 am)

Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts, David Brownell, (Sun Jun 29, 11:09 pm)

Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts, Stefan Becker, (Mon Jun 30, 5:34 am)

Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts, David Brownell, (Mon Jun 30, 7:15 am)

Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts, David Brownell, (Mon Jun 30, 3:57 pm)

Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts, Alan Stern, (Mon Jun 30, 10:37 am)

[PATCH] USB: fix interrupt disabling for HCDs with shared in..., Stefan Becker, (Mon Jun 30, 2:53 pm)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., Alan Stern, (Mon Jun 30, 3:35 pm)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., David Brownell, (Mon Jun 30, 4:31 pm)

[PATCH] USB: fix interrupt disabling for HCDs with shared in..., Stefan Becker, (Mon Jun 30, 5:26 pm)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., Alan Stern, (Tue Jul 1, 10:11 am)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., David Brownell, (Tue Jul 1, 12:22 pm)

[PATCH] USB: fix interrupt disabling for HCDs with shared in..., Stefan Becker, (Tue Jul 1, 12:19 pm)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., Greg KH, (Tue Jul 1, 2:25 pm)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., Stefan Becker, (Tue Jul 1, 3:15 pm)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., Greg KH, (Tue Jul 1, 3:51 pm)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., Alan Stern, (Tue Jul 1, 2:59 pm)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., David Brownell, (Tue Jul 1, 3:21 pm)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., Greg KH, (Tue Jul 1, 3:13 pm)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., Leonardo Chiquitto, (Tue Jul 1, 10:19 am)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., Alan Stern, (Mon Jun 30, 5:29 pm)

Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., David Brownell, (Mon Jun 30, 5:48 pm)

Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts, Stefan Becker, (Mon Jun 30, 1:22 am)

Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts, Henrique de Moraes Holschuh..., (Mon Jun 30, 10:28 am)

Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts, Alan Cox, (Mon Jun 30, 10:26 am)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Stefan Becker, (Sat Jun 28, 10:36 am)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., David Brownell, (Fri Jun 27, 12:07 pm)

Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., Stefan Becker, (Sat Jun 28, 10:31 am)

Navigation

Popular discussions


linux-kernel:
Greg Kroah-Hartman	[PATCH 004/196] Chinese: add translation of SubmittingPatches
Alan Stern	Re: 2.6.22-rc2-mm1
Satyam Sharma	Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
William Lee Irwin III	Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]
git:

linux-netdev:
Dale Farnsworth	Re: [PATCH 03/39] mv643xx_eth: shorten reg names
Jarek Poplawski	Re: HTB accuracy for high speed
Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Colocation donated by:

Who's online

There are currently 8 users and 1032 guests online.

Online users

Syndicate