Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Woodhouse
Date: Monday, June 30, 2008 - 2:34 am

On Thu, 2008-06-05 at 12:06 -0400, Chas Williams (CONTRACTOR) wrote:

Sorry for dropping this; I'll let it go through the net tree now it's
there.

A couple of comments though... it looks like you forgot to add
MODULE_FIRMWARE(). And shouldn't 'fw_data' in
fore200e_load_and_start_firmware() be a (__le32 *) not a (u32 *)?

-- 
dwmw2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 15/19] Filesystem: XFS slab defragmentation, Christoph Lameter, (Fri May 9, 7:21 pm)
Re: [PATCH] firmware: convert Ambassador ATM driver to req ..., Chas Williams (CONTR ..., (Thu Jun 5, 9:06 am)
Re: [PATCH] firmware: convert Ambassador ATM driver to req ..., Chas Williams (CONTR ..., (Thu Jun 5, 11:20 am)
Re: [PATCH] firmware: convert Ambassador ATM driver to req ..., Chas Williams (CONTR ..., (Fri Jun 6, 9:06 am)
Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassad ..., David Woodhouse, (Mon Jun 30, 2:34 am)
Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassad ..., Chas Williams (CONTR ..., (Mon Jun 30, 5:50 am)
Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassad ..., Chas Williams (CONTR ..., (Mon Jun 30, 5:59 am)
Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassad ..., Chas Williams (CONTR ..., (Mon Jun 30, 6:15 am)
Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassad ..., Chas Williams (CONTR ..., (Mon Jun 30, 6:59 am)
Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassad ..., Chas Williams (CONTR ..., (Mon Jun 30, 9:10 am)
Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassad ..., Chas Williams (CONTR ..., (Tue Jul 1, 5:55 am)
Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassad ..., Chas Williams (CONTR ..., (Tue Jul 1, 9:17 am)
Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassad ..., Chas Williams (CONTR ..., (Wed Jul 9, 1:37 pm)
Re: [patch 15/19] Filesystem: XFS slab defragmentation, Dave Chinner, (Sat Aug 2, 6:42 pm)
Re: [patch 15/19] Filesystem: XFS slab defragmentation, Christoph Lameter, (Mon Aug 4, 6:36 am)