linux-kernel mailing list

FromSubjectsort iconDate
Johannes Weiner
Longstanding bug in ac97/intel8x0 resume/init
Hi, my laptop has muted sound after resuming the soundcard (by s2ram/hibernation). The problem seems to be that the cached register values are not written back to the device properly. Before suspend, the registers look like this: 0:00 = 1990 0:02 = 0000 0:04 = 9f1f 0:06 = 801f 0:08 = 0000 0:0a = 801e 0:0c = 801f 0:0e = 801f 0:10 = 9f1f 0:12 = 9f1f 0:14 = 9f1f 0:16 = 9f1f 0:18 = 0b0b 0:1a = 0000 0:1c = 0000 0:1e = 0000 0:20 = 0000 0:22 = 0000 0:24 = 0000 0:26 = 000f 0:28 = 020...
Jun 3, 7:31 pm 2008
Yan Li
Re: 2.6.24 Kernel Soft Lock Up with heavy I/O in dm-crypt
I think they are not the same. My problem lied in the slow crypto computation under heavy I/O. I'm testing Milan Broz's patch, till now it seems has solved my problem. -- Li, Yan --
Jun 3, 7:13 pm 2008
Cliff Wickman
[PATCH 1/1] SGI UV: TLB shootdown using broadcast assist unit
From: Cliff Wickman <cpw@sgi.com> TLB shootdown for SGI UV. This patch provides the ability to flush TLB's in cpu's that are not on the local node. The hardware mechanism for distributing the flush messages is the UV's "broadcast assist unit". The hook to intercept TLB shootdown requests is a 2-line change to native_flush_tlb_others() (arch/x86/kernel/tlb_64.c). This code has been tested on a hardware simulator. The real hardware is not yet available. The shootdown statistics a...
Jun 3, 6:44 pm 2008
Michael Kerrisk
[parch 4/4] vfs: utimensat(): fix write access check for fut...
The POSIX.1 draft spec for futimens()/utimensat() says: Only a process with the effective user ID equal to the user ID of the file, *or with write access to the file*, or with appropriate privileges may use futimens() or utimensat() with a null pointer as the times argument or with both tv_nsec fields set to the special value UTIME_NOW. The important piece here is "with write access to the file", and this matters for futimens(), which deals with an...
Jun 3, 6:25 pm 2008
Michael Kerrisk
[parch 3/4] vfs: utimensat(): fix error checking for {UTIME_...
The POSIX.1 draft spec for utimensat() says that to do anything other than setting both timestamps to a time other than the current time (i.e., times is not NULL, and both tv_nsec fields are not UTIME_NOW and both tv_nsec fields are not UTIME_OMIT), either: a) the caller's effective user ID must match the file owner; or b) the caller must have appropriate privileges. If this condition is violated, then the error EPERM should result. However, the current implementation does not generate EPERM if ...
Jun 3, 6:25 pm 2008
Michael Kerrisk
[parch 2/4] vfs: utimensat(): be consistent with utime() for...
This patch fixes utimensat() to make its behavior consistent with that of utime()/utimes() when dealing with files marked immutable and append-only. The current utimensat() implementation also returns EPERM if 'times' is non-NULL and the tv_nsec fields are both UTIME_NOW. For consistency, the (times != NULL && times[0].tv_nsec == UTIME_NOW && times[1].tv_nsec == UTIME_NOW) case should be treated like the traditional utimes() case where 'times' is NULL. That ...
Jun 3, 6:25 pm 2008
Michael Kerrisk
[parch 1/4] vfs: utimensat(): ignore tv_sec if tv_nsec == UT...
The POSIX.1 draft spec for utimensat() says that if a times[n].tv_nsec field is UTIME_OMIT or UTIME_NOW, then the value in the corresponding tv_sec field is ignored. However the current Linux implementation requires the tv_sec value to be zero (or the EINVAL error results). This requirement should be removed. CC: Miklos Szeredi <miklos@szeredi.hu> CC: Al Viro <viro@zeniv.linux.org.uk> CC: Ulrich Drepper <drepper@redhat.com> Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.c...
Jun 3, 6:24 pm 2008
Michael Kerrisk
[parch 0/4] vfs: fix utimensat() non-conformances to spec
Andrew, As requested I've split the patch I sent earlier today ("utimensat() non-conformances and fixes [v4] (patch)") into four parts. Ideally, these should be applied for 2.6.26-rc, for the reasons outlined in my earlier mail "utimensat() non-conformances and fixes [v4] (test results)". The four patches can be applied independently, but patch 3 needs patch 2 in order to work properly. My apologies for not doing this right the first time round, and hopefully I did get it all right this time...
Jun 3, 6:24 pm 2008
Cliff Wickman
Re: [BUG] hotplug cpus on ia64
Yes! It does. Dimitri Sivanich has run into what looks like a similar problem. Hope the above workaround is a good clue to its solution. -- Cliff Wickman Silicon Graphics, Inc. cpw@sgi.com (651) 683-3824 --
Jun 3, 6:17 pm 2008
Justin Mattock
kgdbts: BP mismatch c010852a expected c02753e0
Hello; I decided to turn kgdb on just for the heck of it, I noticed this once I rebooted: [ 1.691997] kgdb: Registered I/O driver kgdbts. [ 1.692485] kgdbts:RUN plant and detach test [ 1.709377] kgdbts:RUN sw breakpoint test [ 1.709377] kgdbts:RUN bad memory access test [ 1.709377] kgdbts:RUN singlestep test 1000 iterations [ 1.712049] kgdbts:RUN singlestep [0/1000] [ 1.721988] kgdbts:RUN singlestep [100/1000] [ 1.739330] kgdbts:RUN singlestep [200/1000] [ 1.748869] kgdb...
Jun 3, 6:06 pm 2008
Dennis Gilmore
Re: [BUG] 2.6.26-rc1 broke X on SPARC Ultra5
well i can confirm that X server 1.5 works fine on 2.6.25.4 not that its=20 unexpected. Dennis
Jun 3, 5:30 pm 2008
Sam Ravnborg
[RFC PATCH] drop support for KALLSYMS_EXTRA_PASS
We have not seen any reports on inconsistent kallsysms data recently as in the last one or two years. At least I do not recall these and google had no hits in my searching. So I suggest removing this as to simplify the final linking. When doing "make allyesconfig" build this extra linking takes considerably time (and I usually forgoet to turn it off). In addition this patch removes the debug target: debug_kallsyms Sam Suggested patch: diff --git a/Makefile b/Makefile index 8db70fe..911c...
Jun 3, 5:07 pm 2008
David Miller
Re: [BUG] 2.6.26-rc1 broke X on SPARC Ultra5
From: "Raimo Schmidt" <raimoschmidt@gmail.com> The patch discussed here is sparc64 specific so won't in any way help your case on a PC, sorry. --
Jun 3, 4:13 pm 2008
David Miller
[PATCH 12/12]: wext: Emit event stream entries correctly whe...
Three major portions to this change: 1) Add IW_EV_COMPAT_LCP_LEN, IW_EV_COMPAT_POINT_OFF, and IW_EV_COMPAT_POINT_LEN helper defines. 2) Delete iw_stream_check_add_*(), they are unused. 3) Add iw_request_info argument to iwe_stream_add_*(), and use it to size the event and pointer lengths correctly depending upon whether IW_REQUEST_FLAG_COMPAT is set or not. 4) The mechanical transformations to the drivers and wireless stack bits to get the iw_request_info passed down into the r...
Jun 3, 4:28 pm 2008
Larry Finger
Re: [PATCH 12/12]: wext: Emit event stream entries correctly...
David, What tree should be used for this patch? On wireless-testing that git-describe lists as v2.6.26-rc4-8782-gd9a8bd7, hunk 5 for mlme.c fails. Larry --
Jun 3, 6:00 pm 2008
David Miller
Re: [PATCH 12/12]: wext: Emit event stream entries correctly...
From: Larry Finger <Larry.Finger@lwfinger.net> I said in the 0/12 posting that the patches are based upon net-next-2.6 --
Jun 3, 6:03 pm 2008
Johannes Berg
Re: [PATCH 12/12]: wext: Emit event stream entries correctly...
Awesome stuff. With respect to wpa supplicant, I'd expect we need some sort of handling for this wrt. notifications (multicast) which is a bit Did you miss drivers/net/ps3_gelic_wireless.c? johannes
Jun 3, 4:48 pm 2008
David Miller
Re: [PATCH 12/12]: wext: Emit event stream entries correctly...
From: Johannes Berg <johannes@sipsolutions.net> Likely yes, I guess that won't get hit with an allmodconfig build on sparc64 :( It would be really nice if we had some more compat layers so that the ps3 bus probing layer just nopped out but you could at least build test drivers on other platforms. --
Jun 3, 4:57 pm 2008
David Miller
Re: [PATCH 12/12]: wext: Emit event stream entries correctly...
From: David Miller <davem@davemloft.net> Here is a respin of patch 12 with the ps3 bits included, thank for noticing Johannes. I've also respun the tree on kernel.org so that it's fixed there too. wext: Emit event stream entries correctly when compat. Three major portions to this change: 1) Add IW_EV_COMPAT_LCP_LEN, IW_EV_COMPAT_POINT_OFF, and IW_EV_COMPAT_POINT_LEN helper defines. 2) Delete iw_stream_check_add_*(), they are unused. 3) Add iw_request_info argument to iwe_str...
Jun 3, 5:08 pm 2008
David Miller
[PATCH 5/12]: wext: Pull ioctl permission checking out into ...
Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 22 +++++++++++++++------- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index a1cd19a..e96559e 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -1061,18 +1061,26 @@ static int wireless_process_ioctl(struct net *net, struct ifreq *ifr, unsigned i return -EOPNOTSUPP; } +/* If command is `set a parameter', or `get the encoding para...
Jun 3, 3:20 pm 2008
David Miller
[PATCH 10/12]: wext: Remove compat handling from fs/compat_i...
No longer used. Signed-off-by: David S. Miller <davem@davemloft.net> --- fs/compat_ioctl.c | 107 +---------------------------------------------------- 1 files changed, 1 insertions(+), 106 deletions(-) diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c index 8ab850b..05ec7ee 100644 --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c @@ -58,7 +58,6 @@ #include <linux/syscalls.h> #include <linux/i2c.h> #include <linux/i2c-dev.h> -#include <linux/wireless.h> ...
Jun 3, 4:28 pm 2008
David Miller
[PATCH 8/12]: wext: Pull top-level ioctl dispatch logic into...
Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 26 ++++++++++++++++++++------ 1 files changed, 20 insertions(+), 6 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index b72cdd2..91cf548 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -1079,8 +1079,10 @@ static int wext_permission_check(unsigned int cmd) } /* entry point from dev ioctl */ -int wext_handle_ioctl(struct net *net, struct ifreq *ifr, unsigned int cmd, ...
Jun 3, 3:20 pm 2008
David Miller
[PATCH 0/12]: Proper compat WEXT support.
This is a refresh of my previous WEXT compat patch set. I've actually tested these exact patches on sparc64 with a RNDIS based USB wireless device from Linksys. I was able to perform iwconfig commands, check iwlist, bring up the interface and use it properly. All with 32-bit tools. I've also done an allmodconfig sanity build check on sparc64. The one thing I was not able to test yet is wpa_supplicant use, and that likely doesn't work properly yet, but we can fix that on top and these patches...
Jun 3, 3:19 pm 2008
David Miller
[PATCH 2/12]: wext: Make adjust_priv_size() take a "struct i...
Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index e83d74a..cd2cf9f 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -512,9 +512,9 @@ static int get_priv_size(__u16 args) /* * Re-calculate the size of private arguments */ -static int adjust_priv_size(__u16 args, union iwreq_data *wrqu) +static int adjust_priv_size(__u...
Jun 3, 3:19 pm 2008
David Miller
[PATCH 1/12]: wext: Remove inline from get_priv_size() and a...
The compiler inlines when appropriate. Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index 947188a..e83d74a 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -500,7 +500,7 @@ static int call_commit_handler(struct net_device *dev) /* * Calculate size of private arguments */ -static inline int get_priv_size(__u16 args) ...
Jun 3, 4:28 pm 2008
David Miller
[PATCH 6/12]: wext: Parameterize the standard/private handle...
The WEXT standard and private handlers to use are now arguments to wireless_process_ioctl(). Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 24 ++++++++++++++++-------- 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index e96559e..929d241 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -1015,11 +1015,17 @@ static int ioctl_private_call(struct net_device *dev, struct ifreq *ifr, ...
Jun 3, 4:28 pm 2008
David Miller
[PATCH 9/12]: wext: Dispatch and handle compat ioctls entire...
Next we can kill the hacks in fs/compat_ioctl.c and also dispatch compat ioctls down into the driver and 80211 protocol helper layers in order to handle iw_point objects embedded in stream replies which need to be translated. Signed-off-by: David S. Miller <davem@davemloft.net> --- fs/compat_ioctl.c | 6 --- include/linux/wireless.h | 13 ++++++ include/net/wext.h | 7 +++ net/socket.c | 10 ++++ net/wireless/wext.c | 104 ++++++++++++++++++++++++...
Jun 3, 3:20 pm 2008
David Miller
[PATCH 0/12]: Proper compat WEXT support.
This is a refresh of my previous WEXT compat patch set. I've actually tested these exact patches on sparc64 with a RNDIS based USB wireless device from Linksys. I was able to perform iwconfig commands, check iwlist, bring up the interface and use it properly. All with 32-bit tools. I've also done an allmodconfig sanity build check on sparc64. The one thing I was not able to test yet is wpa_supplicant use, and that likely doesn't work properly yet, but we can fix that on top and these patches...
Jun 3, 4:27 pm 2008
David Miller
[PATCH 11/12]: wext: Create IW_REQUEST_FLAG_COMPAT and set i...
Now low-level WEXT ioctl handlers can do compat handling when necessary. Signed-off-by: David S. Miller <davem@davemloft.net> --- include/net/iw_handler.h | 2 +- net/wireless/wext.c | 73 +++++++++++++++++++++------------------------- 2 files changed, 34 insertions(+), 41 deletions(-) diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h index 369d50e..c99a8ee 100644 --- a/include/net/iw_handler.h +++ b/include/net/iw_handler.h @@ -256,7 +256,7 @@ #define EIWC...
Jun 3, 4:28 pm 2008
David Miller
[PATCH 10/12]: wext: Remove compat handling from fs/compat_i...
No longer used. Signed-off-by: David S. Miller <davem@davemloft.net> --- fs/compat_ioctl.c | 107 +---------------------------------------------------- 1 files changed, 1 insertions(+), 106 deletions(-) diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c index 8ab850b..05ec7ee 100644 --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c @@ -58,7 +58,6 @@ #include <linux/syscalls.h> #include <linux/i2c.h> #include <linux/i2c-dev.h> -#include <linux/wireless.h> ...
Jun 3, 3:20 pm 2008
David Miller
[PATCH 11/12]: wext: Create IW_REQUEST_FLAG_COMPAT and set i...
Now low-level WEXT ioctl handlers can do compat handling when necessary. Signed-off-by: David S. Miller <davem@davemloft.net> --- include/net/iw_handler.h | 2 +- net/wireless/wext.c | 73 +++++++++++++++++++++------------------------- 2 files changed, 34 insertions(+), 41 deletions(-) diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h index 369d50e..c99a8ee 100644 --- a/include/net/iw_handler.h +++ b/include/net/iw_handler.h @@ -256,7 +256,7 @@ #define EIWC...
Jun 3, 3:20 pm 2008
David Miller
[PATCH 7/12]: wext: Pass iwreq pointer down into standard/pr...
They have no need to see the object as an ifreq. Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 17 ++++++++--------- 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index 929d241..b72cdd2 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -832,11 +832,10 @@ out: * user space and kernel space. */ static int ioctl_standard_call(struct net_device * dev, - struct ifreq * ...
Jun 3, 3:20 pm 2008
David Miller
[PATCH 4/12]: wext: Extract private call iw_point handling i...
Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 141 +++++++++++++++++++++++++++------------------------ 1 files changed, 74 insertions(+), 67 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index d17c0f4..a1cd19a 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -890,25 +890,22 @@ static int ioctl_standard_call(struct net_device * dev, * a iw_handler but process it in your ioctl handler (i.e. use the * old driver API)....
Jun 3, 4:28 pm 2008
David Miller
[PATCH 2/12]: wext: Make adjust_priv_size() take a "struct i...
Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index e83d74a..cd2cf9f 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -512,9 +512,9 @@ static int get_priv_size(__u16 args) /* * Re-calculate the size of private arguments */ -static int adjust_priv_size(__u16 args, union iwreq_data *wrqu) +static int adjust_priv_size(__u...
Jun 3, 4:28 pm 2008
David Miller
[PATCH 5/12]: wext: Pull ioctl permission checking out into ...
Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 22 +++++++++++++++------- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index a1cd19a..e96559e 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -1061,18 +1061,26 @@ static int wireless_process_ioctl(struct net *net, struct ifreq *ifr, unsigned i return -EOPNOTSUPP; } +/* If command is `set a parameter', or `get the encoding para...
Jun 3, 4:28 pm 2008
David Miller
[PATCH 6/12]: wext: Parameterize the standard/private handle...
The WEXT standard and private handlers to use are now arguments to wireless_process_ioctl(). Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 24 ++++++++++++++++-------- 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index e96559e..929d241 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -1015,11 +1015,17 @@ static int ioctl_private_call(struct net_device *dev, struct ifreq *ifr, ...
Jun 3, 3:20 pm 2008
David Miller
[PATCH 3/12]: wext: Extract standard call iw_point handling ...
Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 258 ++++++++++++++++++++++++++------------------------ 1 files changed, 134 insertions(+), 124 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index cd2cf9f..d17c0f4 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -694,6 +694,138 @@ void wext_proc_exit(struct net *net) */ /* ---------------------------------------------------------------- */ +static int ioctl_standar...
Jun 3, 3:20 pm 2008
David Miller
[PATCH 7/12]: wext: Pass iwreq pointer down into standard/pr...
They have no need to see the object as an ifreq. Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 17 ++++++++--------- 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index 929d241..b72cdd2 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -832,11 +832,10 @@ out: * user space and kernel space. */ static int ioctl_standard_call(struct net_device * dev, - struct ifreq * ...
Jun 3, 4:28 pm 2008
David Miller
[PATCH 3/12]: wext: Extract standard call iw_point handling ...
Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 258 ++++++++++++++++++++++++++------------------------ 1 files changed, 134 insertions(+), 124 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index cd2cf9f..d17c0f4 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -694,6 +694,138 @@ void wext_proc_exit(struct net *net) */ /* ---------------------------------------------------------------- */ +static int ioctl_standar...
Jun 3, 4:28 pm 2008
David Miller
[PATCH 9/12]: wext: Dispatch and handle compat ioctls entire...
Next we can kill the hacks in fs/compat_ioctl.c and also dispatch compat ioctls down into the driver and 80211 protocol helper layers in order to handle iw_point objects embedded in stream replies which need to be translated. Signed-off-by: David S. Miller <davem@davemloft.net> --- fs/compat_ioctl.c | 6 --- include/linux/wireless.h | 13 ++++++ include/net/wext.h | 7 +++ net/socket.c | 10 ++++ net/wireless/wext.c | 104 ++++++++++++++++++++++++...
Jun 3, 4:28 pm 2008
David Miller
[PATCH 4/12]: wext: Extract private call iw_point handling i...
Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 141 +++++++++++++++++++++++++++------------------------ 1 files changed, 74 insertions(+), 67 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index d17c0f4..a1cd19a 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -890,25 +890,22 @@ static int ioctl_standard_call(struct net_device * dev, * a iw_handler but process it in your ioctl handler (i.e. use the * old driver API)....
Jun 3, 3:20 pm 2008
David Miller
[PATCH 1/12]: wext: Remove inline from get_priv_size() and a...
The compiler inlines when appropriate. Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index 947188a..e83d74a 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -500,7 +500,7 @@ static int call_commit_handler(struct net_device *dev) /* * Calculate size of private arguments */ -static inline int get_priv_size(__u16 args) ...
Jun 3, 3:19 pm 2008
David Miller
[PATCH 8/12]: wext: Pull top-level ioctl dispatch logic into...
Signed-off-by: David S. Miller <davem@davemloft.net> --- net/wireless/wext.c | 26 ++++++++++++++++++++------ 1 files changed, 20 insertions(+), 6 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index b72cdd2..91cf548 100644 --- a/net/wireless/wext.c +++ b/net/wireless/wext.c @@ -1079,8 +1079,10 @@ static int wext_permission_check(unsigned int cmd) } /* entry point from dev ioctl */ -int wext_handle_ioctl(struct net *net, struct ifreq *ifr, unsigned int cmd, ...
Jun 3, 4:28 pm 2008
David Miller
[PATCH 12/12]: wext: Emit event stream entries correctly whe...
Three major portions to this change: 1) Add IW_EV_COMPAT_LCP_LEN, IW_EV_COMPAT_POINT_OFF, and IW_EV_COMPAT_POINT_LEN helper defines. 2) Delete iw_stream_check_add_*(), they are unused. 3) Add iw_request_info argument to iwe_stream_add_*(), and use it to size the event and pointer lengths correctly depending upon whether IW_REQUEST_FLAG_COMPAT is set or not. 4) The mechanical transformations to the drivers and wireless stack bits to get the iw_request_info passed down into the r...
Jun 3, 3:20 pm 2008
Michael Kerrisk
utimensat() non-conformances and fixes [v4] (test results)
Andrew, The following is why I think my patch should preferably be applied for 2.6.26, rather than waiting for .27. The first reason is the obvious. The test suite runs 99 tests. With my patch applied to 2.6.24-rc4, all tests pass (see the attached test results). There is another reason why I think we should apply the patch for .26. On 2.6.25, we have: Total tests: 99; passed: 73; failed: 26 On 2.6.26-rc4, we have: Total tests: 99; passed: 74; failed: 25 As far as I can see, thi...
Jun 3, 4:15 pm 2008
Michael Kerrisk
utimensat() non-conformances and fixes [v4] (test suite)
Andrew, Attached are two files: test_utimensat.c a program that can be used to perform command-line-driven tests of most aspects of the operation of utimensat(). utimensat_tests.sh a shell script that uses the preceding C program to perform a battery of tests against utimensat(). Cheers, Michael
Jun 3, 4:14 pm 2008
Michael Kerrisk
utimensat() non-conformances and fixes [v4] (patch)
Andrew, This patch fixes all of the utimensat() bugs outlined in my previous mail. I could have split the patch out into a few pieces, but given that it is not long, and all against a single file, I've made one patch. Let me know if you would like separate patches for the pieces below. Miklos suggested an alternative idea, migrating the is_owner_or_cap() check into fs/attr.c:inode_change_ok() via the use of an ATTR_OWNER_CHECK flag. Maybe we could do that later, but for now I've one with t...
Jun 3, 4:13 pm 2008
Andrew Morton
Re: utimensat() non-conformances and fixes [v4] (patch)
On Tue, 03 Jun 2008 22:13:58 +0200 Well I think it would have been better, really. Right now someone (apparently me) needs to take the text from "utimensat() non-conformances and fixes [v4] (overview)" and weave it together with the text from "utimensat() non-conformances and fixes [v4] (patch)" to produce a vaguely coherent changelog. It all would be much saner and cleaner if each of these changes was in a self-contained diff which had its own standalone changelog, no? --
Jun 3, 4:22 pm 2008
Michael Kerrisk
Re: utimensat() non-conformances and fixes [v4] (patch)
On Tue, Jun 3, 2008 at 10:22 PM, Andrew Morton Okay -- let me take a shot at it. I'll try to get back to you in an hour or so. -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html --
Jun 3, 4:29 pm 2008
Michael Kerrisk
utimensat() non-conformances and fixes [v4] (overview)
Andrew, A follow-on to this mail is a patch (against 2.6.26-rc4) for -mm. The patch fixes several problems in the utimensat() system call. I would like to see this patch get into mainline ASAP. If you don't want to push it for .26, I can understand that, since we are late in the cycle. Nevertheless, I will provide some arguments in favor of doing so, in a follow-on mail. (I'll also provide a fairly comprehensive test suite, and test results, which may make you feel fairly confident of the pat...
Jun 3, 4:13 pm 2008
previous daytodaynext day
June 2, 2008June 3, 2008June 4, 2008