Re: [BUG] CFS vs cpu hotplug

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Dmitry Adamushko
Date: Saturday, June 28, 2008 - 3:16 pm

Hello,


it seems to be related to migrate_dead_tasks().

Firstly I added traces to see all tasks being migrated with
migrate_live_tasks() and migrate_dead_tasks(). On my setup the problem
pops up (the one with "se == NULL" in the loop of
pick_next_task_fair()) shortly after the traces indicate that some has
been migrated with migrate_dead_tasks()). btw., I can reproduce it
much faster now with just a plain cpu down/up loop.

[disclaimer] Well, unless I'm really missing something important in
this late hour [/desclaimer] pick_next_task() is not something
appropriate for migrate_dead_tasks() :-)

the following change seems to eliminate the problem on my setup
(although, I kept it running only for a few minutes to get a few
messages indicating migrate_dead_tasks() does move tasks and the
system is still ok)

[ quick hack ]

@@ -5887,6 +5907,7 @@ static void migrate_dead_tasks(unsigned int dead_cpu)
                next = pick_next_task(rq, rq->curr);
                if (!next)
                        break;
+               next->sched_class->put_prev_task(rq, next);
                migrate_dead(dead_cpu, next);

        }

just in case, all the changes I've used for this test are attached "as is".

p.s. perhaps I won't be able to verify it carefully till tomorrow's
late evening.


-- 
Best regards,
Dmitry Adamushko
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[BUG] CFS vs cpu hotplug, Heiko Carstens, (Thu Jun 19, 9:19 am)
Re: [BUG] CFS vs cpu hotplug, Peter Zijlstra, (Thu Jun 19, 11:05 am)
Re: [BUG] CFS vs cpu hotplug, Peter Zijlstra, (Thu Jun 19, 11:14 am)
Re: [BUG] CFS vs cpu hotplug, Heiko Carstens, (Thu Jun 19, 2:14 pm)
Re: [BUG] CFS vs cpu hotplug, Heiko Carstens, (Thu Jun 19, 2:17 pm)
Re: [BUG] CFS vs cpu hotplug, Peter Zijlstra, (Thu Jun 19, 2:26 pm)
Re: [BUG] CFS vs cpu hotplug, Peter Zijlstra, (Thu Jun 19, 2:32 pm)
Re: [BUG] CFS vs cpu hotplug, Heiko Carstens, (Thu Jun 19, 2:49 pm)
Re: [BUG] CFS vs cpu hotplug, Peter Zijlstra, (Fri Jun 20, 1:51 am)
Re: [BUG] CFS vs cpu hotplug, Dmitry Adamushko, (Fri Jun 20, 4:44 am)
Re: [BUG] CFS vs cpu hotplug, Heiko Carstens, (Fri Jun 20, 3:19 pm)
Re: [BUG] CFS vs cpu hotplug, Heiko Carstens, (Fri Jun 20, 3:23 pm)
Re: [BUG] CFS vs cpu hotplug, Dmitry Adamushko, (Wed Jun 25, 3:12 pm)
Re: [BUG] CFS vs cpu hotplug, Dmitry Adamushko, (Sat Jun 28, 3:16 pm)
Re: [BUG] CFS vs cpu hotplug, Ingo Molnar, (Sat Jun 28, 11:55 pm)
Re: [BUG] CFS vs cpu hotplug, Heiko Carstens, (Mon Jun 30, 2:07 am)
Re: [BUG] CFS vs cpu hotplug, Ingo Molnar, (Mon Jun 30, 2:17 am)
Re: [BUG] CFS vs cpu hotplug, Lai Jiangshan, (Tue Jul 1, 2:22 am)
Re: [BUG] CFS vs cpu hotplug, Ingo Molnar, (Tue Jul 1, 2:31 am)
Re: [BUG] CFS vs cpu hotplug, Lai Jiangshan, (Tue Jul 1, 3:09 am)
Re: [BUG] CFS vs cpu hotplug, Lai Jiangshan, (Wed Jul 2, 12:13 am)
Re: [BUG] CFS vs cpu hotplug, Dmitry Adamushko, (Wed Jul 2, 1:50 am)
Re: [BUG] CFS vs cpu hotplug, Lai Jiangshan, (Wed Jul 2, 2:23 am)
Re: [BUG] CFS vs cpu hotplug, Miao Xie, (Mon Jul 7, 3:26 am)
Re: [BUG] CFS vs cpu hotplug, Dmitry Adamushko, (Mon Jul 7, 4:31 am)