Re: [REGRESSION] 2.6.24/25: random lockups when accessing external USB harddrive

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Stefan Becker <Stefan.Becker@...>
Cc: ext Alan Stern <stern@...>, <linux-kernel@...>, <linux-usb@...>
Date: Friday, June 27, 2008 - 12:07 pm

On Thursday 26 June 2008, Stefan Becker wrote:

I'll let Alan look at that one, but:



No, but it suggests a few ways to get closer to the root cause.

That looks fishy.   The IRQ handler does not re-enable IRQs,
so it looks like something re-enabled IRQs in the middle of
an IRQ handler!  Which will obviously cause trouble.

(I'll assume that this isn't a case of a misleading stack dump,
where the IRQ frames are dead ones that were wrongly dumped...)

If 442258e2ff69276ff767f3703b30ce6a31fdd181 isn't in the
kernel with those bugs, try applying it... else, I suggest
you try putting something like your

	if (!raw_irqs_disabled()) {
		printk(KERN_CRIT "interrupts enabled!\n");
		dump_stack();
        }

logic at the beginning and end of usb_hcd_giveback_urb ... and
maybe have it dump the address of the completion handler, when
you can finger such a handler as re-enabling IRQs.

- Dave
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
BUG in 2.6.26-rc8 interrupt handling, Becker Stefan (Nokia-D/Salo)..., (Sat Jun 28, 3:34 pm)
Re: BUG in 2.6.26-rc8 interrupt handling, David Brownell, (Sat Jun 28, 3:51 pm)
PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts, Stefan Becker, (Sun Jun 29, 10:57 am)
Re: [PATCH] USB: fix interrupt disabling for HCDs with share..., Leonardo Chiquitto, (Tue Jul 1, 10:19 am)
Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts, Henrique de Moraes Holschuh..., (Mon Jun 30, 10:28 am)
Re: [REGRESSION] 2.6.24/25: random lockups when accessing ex..., David Brownell, (Fri Jun 27, 12:07 pm)