On Wednesday 25 June 2008, Jonathan Corbet wrote:
quoted text
> On Sun, 22 Jun 2008 19:55:42 -0700
> David Brownell <david-b@pacbell.net> wrote:
> 
> > Remove implicit use of BKL in ioctl() from the RTC framework.
> 
> Looks good, I'll happily put it into the bkl-removal tree.

It's in MM now too ... are all the bkl-removal patches going in
at once, or will they be merged through their subsystems?


quoted text
> One question, though:
> 
> > +	err = mutex_lock_interruptible(&rtc->ops_lock);
> > +	if (err)
> > +		return -EBUSY;
> > +
> 
> Shouldn't that be -EINTR?

I was just copying that usage from drivers/rtc/interface.c ...
all users there return -EBUSY.

If it's wrong in this patch it's probably wrong there too.
I suspect EINTR is the answer in all cases.

- Dave
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/