login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
June
»
25
Re: [patch] x86: shift bits the right way in native_read_tscp
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Glauber Costa <gcosta@...>
To: Max Asbock <masbock@...>
Cc: tglx <tglx@...>, mingo <mingo@...>, hpa <hpa@...>, <linux-kernel@...>
Subject:
Re: [patch] x86: shift bits the right way in native_read_tscp
Date: Wednesday, June 25, 2008 - 5:51 pm
Max Asbock wrote:
quoted text
> native_read_tscp shifts the bits in the high order value in the wrong direction, > the attached patch fixes that. > > Signed-off-by: Max Asbock <masbock@linux.vnet.ibm.com> > > diff -pburN linux/include/asm-x86/msr.h linux.rdtscp/include/asm-x86/msr.h > --- linux/include/asm-x86/msr.h 2008-06-20 11:51:17.000000000 -0700 > +++ linux.rdtscp/include/asm-x86/msr.h 2008-06-25 14:26:35.000000000 -0700 > @@ -18,7 +18,7 @@ static inline unsigned long long native_ > unsigned long low, high; > asm volatile(".byte 0x0f,0x01,0xf9" > : "=a" (low), "=d" (high), "=c" (*aux)); > - return low | ((u64)high >> 32); > + return low | ((u64)high << 32); > } > > /* > > > --- > Max > >
uh-oh! absolutely right shame on me. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[patch] x86: shift bits the right way in native_read_tscp
, Max Asbock
, (Wed Jun 25, 5:45 pm)
Re: [patch] x86: shift bits the right way in native_read_tscp
, Glauber Costa
, (Wed Jun 25, 5:51 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Davide Libenzi
[patch 7/8] fdmap v2 - implement sys_socket2
Greg Kroah-Hartman
[PATCH 018/196] coda: convert struct class_device to struct device
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
David Newall
Re: Slow DOWN, please!!!
git
:
linux-netdev
:
Christoph Lameter
Network latency regressions from 2.6.22 to 2.6.29
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Arjan van de Ven
Re: [GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
3 users
and
633 guests
online.
Online users
starbucksfreak9
whatnevers
Jeremy
Syndicate