Re: [PATCH] x86 ACPI: normalize segment descriptor register on resume

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Wednesday, June 25, 2008 - 10:01 am

* Pavel Machek <pavel@suse.cz> wrote:


sure - i have applied it to tip/out-of-tree. I'm equally nervous about 
this change - it affects every suspend+resume cycle that people do on 
those boxes which are working just fine currently.

btw., it would get a lot more coverage on my test-systems if this commit 
in tip/out-of-tree:

| commit 01259383c345d13b70efcc549439927ae64dc66d
| Author: David Brownell <david-b@pacbell.net>
| Date:   Fri May 16 10:12:36 2008 +0200
|
|     sleepy linux self-test

was upstream and if it was enabled more prominently, instead of hidden 
behind the rather obscure condition of:

  config PM_TEST_SUSPEND
        bool "Test suspend/resume and wakealarm during bootup"
        depends on SUSPEND && PM_DEBUG && RTC_LIB=y

and even then it needs certain other config options related to RTC_LIB 
to actually work during bootup.

As a result of all this obstruction, the automated testing i do, which 
builds and boots more than 1 random kernel per minute, will only run 
this self-test once every hour or so.

I dont mind if this option breaks boxes (that its purpose: it does the 
same thing that a real suspend+resume does and suspend+resume frequently 
breaks boxes), but right now it's all obscured so heavily which makes 
automated testing a lot harder than it should be.

it would be wonderful if this excellent suspend+resume self-test was 
upstream and was more prominent! :-)

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] x86 ACPI: normalize segment descriptor register on ..., Rafael J. Wysocki, (Tue Jun 24, 2:03 pm)
Re: [PATCH] x86 ACPI: normalize segment descriptor registe ..., Ingo Molnar, (Wed Jun 25, 10:01 am)
Re: [PATCH] x86 ACPI: normalize segment descriptor registe ..., Rafael J. Wysocki, (Wed Jun 25, 1:17 pm)
Re: [PATCH] x86 ACPI: normalize segment descriptor registe ..., Rafael J. Wysocki, (Thu Jun 26, 1:35 am)
Re: [PATCH] x86 ACPI: normalize segment descriptor registe ..., Rafael J. Wysocki, (Thu Jun 26, 1:39 am)
Re: [PATCH] x86 ACPI: normalize segment descriptor registe ..., Rafael J. Wysocki, (Thu Jun 26, 1:56 am)