[-mm][PATCH 3/10] fix munlock page table walk - now requires 'mm'

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: KOSAKI Motohiro
Date: Wednesday, June 25, 2008 - 3:03 am

=
From: Lee Schermerhorn <lee.schermerhorn@hp.com>

Against 2.6.26-rc5-mm3.

Initialize the 'mm' member of the mm_walk structure, else the
page table walk doesn't occur, and mlocked pages will not be
munlocked.  This is visible in the vmstats:  

	noreclaim_pgs_munlocked - should equal noreclaim_pgs_mlocked
	  less (nr_mlock + noreclaim_pgs_cleared), but is always zero 
	  [munlock_vma_page() never called]

	noreclaim_pgs_mlockfreed - should be zero [for debug only],
	  but == noreclaim_pgs_mlocked - (nr_mlock + noreclaim_pgs_cleared)


Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

 mm/mlock.c |    1 +
 1 file changed, 1 insertion(+)

Index: b/mm/mlock.c
===================================================================
--- a/mm/mlock.c
+++ b/mm/mlock.c
@@ -301,6 +301,7 @@ static void __munlock_vma_pages_range(st
 		.pmd_entry = __munlock_pmd_handler,
 		.pte_entry = __munlock_pte_handler,
 		.private = &mpw,
+		.mm = mm,
 	};
 
 	VM_BUG_ON(start & ~PAGE_MASK || end & ~PAGE_MASK);


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[-mm][PATCH 2/10] fix printk in show_free_areas(), KOSAKI Motohiro, (Wed Jun 25, 3:02 am)
[-mm][PATCH 3/10] fix munlock page table walk - now requir ..., KOSAKI Motohiro, (Wed Jun 25, 3:03 am)
[-mm][PATCH 7/10] prevent incorrect oom under split_lru, KOSAKI Motohiro, (Wed Jun 25, 3:07 am)
[-mm][PATCH 9/10] memcg: fix mem_cgroup_end_migration() race, KOSAKI Motohiro, (Wed Jun 25, 3:10 am)
Re: [-mm][PATCH 9/10] memcg: fix mem_cgroup_end_migration ..., Daisuke Nishimura, (Wed Jun 25, 3:53 am)
Re: [-mm][PATCH 0/10] memory related bugfix set for 2.6.2 ..., Lee Schermerhorn, (Wed Jun 25, 8:09 am)
Re: [-mm][PATCH 8/10] fix shmem page migration incorrectne ..., KAMEZAWA Hiroyuki, (Fri Jun 27, 1:52 am)
Re: [-mm][PATCH 8/10] fix shmem page migration incorrectne ..., Daisuke Nishimura, (Fri Jun 27, 2:29 am)