[PATCH] ACPI: add standard linux WARN() output to ACPI warnings

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Vegard Nossum <vegard.nossum@...>, Linux Kernel Mailing List <linux-kernel@...>, <linux-acpi@...>, Zhao Yakui <yakui.zhao@...>, Rafael J. Wysocki <rjw@...>, Alexey Starikovskiy <astarikovskiy@...>, Yinghai Lu <yhlu.kernel@...>
Date: Tuesday, June 24, 2008 - 10:34 pm

From: Len Brown <len.brown@intel.com>

Signed-off-by: Len Brown <len.brown@intel.com>
---
...

Maybe something like this would help?
(totally untested)

-Len

diff --git a/drivers/acpi/utilities/utmisc.c b/drivers/acpi/utilities/utmisc.c
index 1f057b7..d53e82c 100644
--- a/drivers/acpi/utilities/utmisc.c
+++ b/drivers/acpi/utilities/utmisc.c
@@ -1028,6 +1028,7 @@ acpi_ut_error(char *module_name, u32 line_number, char *format, ...)
 {
 	va_list args;
 
+	warn_on_slowpath(module_name, line_number);
 	acpi_os_printf("ACPI Error (%s-%04d): ", module_name, line_number);
 
 	va_start(args, format);
@@ -1042,6 +1043,7 @@ acpi_ut_exception(char *module_name,
 {
 	va_list args;
 
+	warn_on_slowpath(module_name, line_number);
 	acpi_os_printf("ACPI Exception (%s-%04d): %s, ", module_name,
 		       line_number, acpi_format_exception(status));
 
@@ -1058,6 +1060,7 @@ acpi_ut_warning(char *module_name, u32 line_number, char *format, ...)
 {
 	va_list args;
 
+	warn_on_slowpath(module_name, line_number);
 	acpi_os_printf("ACPI Warning (%s-%04d): ", module_name, line_number);
 
 	va_start(args, format);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ACPI: don't walk tables if ACPI was disabled, Vegard Nossum, (Fri Jun 20, 9:56 am)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Vegard Nossum, (Fri Jun 20, 4:40 pm)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Vegard Nossum, (Fri Jun 20, 5:27 pm)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Vegard Nossum, (Sat Jun 21, 4:19 am)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Vegard Nossum, (Tue Jun 24, 7:52 am)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Bjorn Helgaas, (Wed Jun 25, 11:08 am)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Bjorn Helgaas, (Thu Jun 26, 12:44 pm)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Bjorn Helgaas, (Tue Jun 24, 11:22 am)
[PATCH] ACPI: add standard linux WARN() output to ACPI warni..., Len Brown, (Tue Jun 24, 10:34 pm)
Re: [PATCH] ACPI: add standard linux WARN() output to ACPI w..., Arjan van de Ven, (Tue Jun 24, 10:49 pm)