Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks | KernelTrap

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: H. Peter Anvin <hpa@...>

To: Paul Jackson <pj@...>

Cc: Yinghai Lu <yhlu.kernel@...>, <akpm@...>, <mingo@...>, <tglx@...>, <steiner@...>, <travis@...>, <linux-kernel@...>, <ying.huang@...>, <andi@...>

Subject: Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks

Date: Tuesday, June 24, 2008 - 9:56 pm

Paul Jackson wrote:
quoted text> Yinghai wrote:
>> Zone PFN ranges:
>>   DMA      0x       0 -> 0x    1000
> 
> Aha - you're right!
> 
> I just earned the Ugly Patch of the Day Award.
> 
> I think changes of "%lu" to "0x%lx" are still ok,
> but changes of "%8lu" to "0x%8lx" (which use 8
> columns, right aligned, space filled format) are
> not ok.
> 

No, that would have to be %#10lx.

	-hpa
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/5 v2] x86 boot: various E820 & EFI related fixe..., Paul Jackson, (Sun Jun 22, 10:21 am)

Re: [PATCH 0/5 v2] x86 boot: various E820 & EFI related ..., Ingo Molnar, (Tue Jun 24, 7:19 am)

Re: [PATCH 0/5 v2] x86 boot: various E820 & EFI related ..., Paul Jackson, (Tue Jun 24, 7:30 am)

Re: [PATCH 0/5 v2] x86 boot: various E820 & EFI related ..., H. Peter Anvin, (Tue Jun 24, 11:45 am)

[PATCH 5/5 v2] x86 boot: more consistently use type int for ..., Paul Jackson, (Sun Jun 22, 10:22 am)

[PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decim..., Paul Jackson, (Sun Jun 22, 10:22 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Yinghai Lu, (Sun Jun 22, 3:38 pm)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Paul Jackson, (Mon Jun 23, 7:09 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Yinghai Lu, (Tue Jun 24, 5:29 pm)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Paul Jackson, (Tue Jun 24, 9:32 pm)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., H. Peter Anvin, (Tue Jun 24, 9:56 pm)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Paul Jackson, (Tue Jun 24, 10:17 pm)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., H. Peter Anvin, (Tue Jun 24, 10:18 pm)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Linus Torvalds, (Tue Jun 24, 10:58 pm)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., H. Peter Anvin, (Wed Jun 25, 1:05 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Paul Jackson, (Tue Jun 24, 11:08 pm)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Linus Torvalds, (Wed Jun 25, 12:04 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Johannes Berg, (Wed Jun 25, 11:00 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Linus Torvalds, (Wed Jun 25, 11:19 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Alexander van Heukelum, (Mon Jun 30, 3:58 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Denys Vlasenko, (Fri Jun 27, 4:43 pm)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Johannes Berg, (Wed Jun 25, 11:34 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Ingo Molnar, (Wed Jun 25, 10:53 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Sam Ravnborg, (Thu Jun 26, 3:14 pm)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Ingo Molnar, (Fri Jun 27, 8:00 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Sam Ravnborg, (Fri Jun 27, 5:25 pm)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Paul Jackson, (Wed Jun 25, 4:04 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., H. Peter Anvin, (Wed Jun 25, 1:01 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Linus Torvalds, (Wed Jun 25, 10:42 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., H. Peter Anvin, (Wed Jun 25, 11:29 am)

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Linus Torvalds, (Tue Jun 24, 11:00 pm)

[PATCH 3/5 v2] x86 boot: allow overlapping early reserve mem..., Paul Jackson, (Sun Jun 22, 10:22 am)

[PATCH 2/5 v2] x86 boot: x86_64 efi compiler warning fix, Paul Jackson, (Sun Jun 22, 10:22 am)

[PATCH 1/5 v2] x86 boot: e820 code indentation fix, Paul Jackson, (Sun Jun 22, 10:21 am)

Navigation

Popular discussions


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
James Bottomley	Re: Announce: Linux-next (Or Andrew's dream :-))
David Woodhouse	Re: [PATCH 2/3] firmware: convert korg1212 driver to use firmware loader exclusively
Kamalesh Babulal	Re: 2.6.24-rc8-mm1 Build Failure on S390x
git:

linux-netdev:
David Miller	[GIT]: Networking
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
KOSAKI Motohiro	[bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"
openbsd-misc:

Colocation donated by:

Who's online

There are currently 2 users and 783 guests online.

Online users

Syndicate