Home » Mailing list archives » linux-kernel » 2008 » June » 25

Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Paul Jackson <pj@...>
To: Yinghai Lu <yhlu.kernel@...>
Cc: <akpm@...>, <mingo@...>, <tglx@...>, <steiner@...>, <travis@...>, <hpa@...>, <linux-kernel@...>, <ying.huang@...>, <andi@...>
Subject: Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks
Date: Tuesday, June 24, 2008 - 9:32 pm

Yinghai wrote:

Aha - you're right!

I just earned the Ugly Patch of the Day Award.

I think changes of "%lu" to "0x%lx" are still ok,
but changes of "%8lu" to "0x%8lx" (which use 8
columns, right aligned, space filled format) are
not ok.

I will redo this patch, without the "0x" prefix
on the space filled fields.  Let me know if that
is better.

Thank-you.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/5 v2] x86 boot: various E820 &amp; EFI related fixe..., Paul Jackson, (Sun Jun 22, 10:21 am)
Re: [PATCH 0/5 v2] x86 boot: various E820 &amp; EFI related ..., Ingo Molnar, (Tue Jun 24, 7:19 am)
Re: [PATCH 0/5 v2] x86 boot: various E820 &amp; EFI related ..., Paul Jackson, (Tue Jun 24, 7:30 am)
Re: [PATCH 0/5 v2] x86 boot: various E820 &amp; EFI related ..., H. Peter Anvin, (Tue Jun 24, 11:45 am)
[PATCH 5/5 v2] x86 boot: more consistently use type int for ..., Paul Jackson, (Sun Jun 22, 10:22 am)
[PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decim..., Paul Jackson, (Sun Jun 22, 10:22 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Yinghai Lu, (Sun Jun 22, 3:38 pm)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Paul Jackson, (Mon Jun 23, 7:09 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Yinghai Lu, (Tue Jun 24, 5:29 pm)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Paul Jackson, (Tue Jun 24, 9:32 pm)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., H. Peter Anvin, (Tue Jun 24, 9:56 pm)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Paul Jackson, (Tue Jun 24, 10:17 pm)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., H. Peter Anvin, (Tue Jun 24, 10:18 pm)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Linus Torvalds, (Tue Jun 24, 10:58 pm)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., H. Peter Anvin, (Wed Jun 25, 1:05 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Paul Jackson, (Tue Jun 24, 11:08 pm)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Linus Torvalds, (Wed Jun 25, 12:04 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Johannes Berg, (Wed Jun 25, 11:00 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Linus Torvalds, (Wed Jun 25, 11:19 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Alexander van Heukelum, (Mon Jun 30, 3:58 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Denys Vlasenko, (Fri Jun 27, 4:43 pm)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Johannes Berg, (Wed Jun 25, 11:34 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Ingo Molnar, (Wed Jun 25, 10:53 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Sam Ravnborg, (Thu Jun 26, 3:14 pm)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Ingo Molnar, (Fri Jun 27, 8:00 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Sam Ravnborg, (Fri Jun 27, 5:25 pm)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Paul Jackson, (Wed Jun 25, 4:04 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., H. Peter Anvin, (Wed Jun 25, 1:01 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Linus Torvalds, (Wed Jun 25, 10:42 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., H. Peter Anvin, (Wed Jun 25, 11:29 am)
Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not d..., Linus Torvalds, (Tue Jun 24, 11:00 pm)
[PATCH 3/5 v2] x86 boot: allow overlapping early reserve mem..., Paul Jackson, (Sun Jun 22, 10:22 am)
[PATCH 2/5 v2] x86 boot: x86_64 efi compiler warning fix, Paul Jackson, (Sun Jun 22, 10:22 am)
[PATCH 1/5 v2] x86 boot: e820 code indentation fix, Paul Jackson, (Sun Jun 22, 10:21 am)