Re: [PATCH] ACPI: don't walk tables if ACPI was disabled

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Len Brown <lenb@...>, <linux-kernel@...>, <linux-acpi@...>, Zhao Yakui <yakui.zhao@...>, Rafael J. Wysocki <rjw@...>, Alexey Starikovskiy <astarikovskiy@...>, Yinghai Lu <yhlu.kernel@...>, Bjorn Helgaas <bjorn.helgaas@...>
Date: Tuesday, June 24, 2008 - 7:52 am

On 6/24/08, Ingo Molnar <mingo@elte.hu> wrote:

No, please don't :-)

It fixes your particular case (the acpi_rtc_init() hunk of the patch),
but the acpi_walk_namespace() part should be changed to a WARN(). But
that is likely to cause a lot of "spurious" reports, so the other acpi
drivers should be fixed as well.

I was waiting for Len to reply, but maybe I can submit the proper fix too.


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ACPI: don't walk tables if ACPI was disabled, Vegard Nossum, (Fri Jun 20, 9:56 am)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Vegard Nossum, (Fri Jun 20, 4:40 pm)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Vegard Nossum, (Fri Jun 20, 5:27 pm)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Vegard Nossum, (Sat Jun 21, 4:19 am)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Vegard Nossum, (Tue Jun 24, 7:52 am)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Bjorn Helgaas, (Wed Jun 25, 11:08 am)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Bjorn Helgaas, (Thu Jun 26, 12:44 pm)
Re: [PATCH] ACPI: don't walk tables if ACPI was disabled, Bjorn Helgaas, (Tue Jun 24, 11:22 am)
Re: [PATCH] ACPI: add standard linux WARN() output to ACPI w..., Arjan van de Ven, (Tue Jun 24, 10:49 pm)