Home » Mailing list archives » linux-kernel » 2008 » June » 23

[patch 08/10] hwmon: (lm85) Fix function RANGE_TO_REG()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Greg KH
Subject: [patch 08/10] hwmon: (lm85) Fix function RANGE_TO_REG()
Date: Monday, June 23, 2008 - 4:04 pm

2.6.25.9-stable review patch.  If anyone has any objections, please let
us know.

------------------ 
From: Jean Delvare <khali@linux-fr.org>

Function RANGE_TO_REG() is broken. For a requested range of 2000 (2
degrees C), it will return an index value of 15, i.e. 80.0 degrees C,
instead of the expected index value of 0. All other values are handled
properly, just 2000 isn't.

The bug was introduced back in November 2004 by this patch:
http://git.kernel.org/?p=linux/kernel/git/tglx/history.git;a=commit;h=1c28d80f19922403...

In Linus' kernel I decided to rewrite the whole function in a way
which was more obviously correct. But for -stable let's just do the
minimal fix.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/hwmon/lm85.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/hwmon/lm85.c
+++ b/drivers/hwmon/lm85.c
@@ -192,7 +192,7 @@ static int RANGE_TO_REG( int range )
 {
 	int i;
 
-	if ( range < lm85_range_map[0] ) { 
+	if (range <= lm85_range_map[0]) {
 		return 0 ;
 	} else if ( range > lm85_range_map[15] ) {
 		return 15 ;

-- 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 00/10] 2.6.28.9-rc2 review, Greg KH, (Mon Jun 23, 4:04 pm)
[patch 08/10] hwmon: (lm85) Fix function RANGE_TO_REG(), Greg KH, (Mon Jun 23, 4:04 pm)
[patch 09/10] hwmon: (adt7473) Initialize max_duty_at_over ..., Greg KH, (Mon Jun 23, 4:04 pm)
[patch 10/10] Fix ZERO_PAGE breakage with vmware, Greg KH, (Mon Jun 23, 4:04 pm)
[patch 05/10] x86: set PAE PHYSICAL_MASK_SHIFT to 44 bits., Greg KH, (Mon Jun 23, 4:04 pm)
[patch 06/10] Add return value to reserve_bootmem_node(), Greg KH, (Mon Jun 23, 4:04 pm)
[patch 07/10] watchdog: hpwdt: fix use of inline assembly, Greg KH, (Mon Jun 23, 4:05 pm)
[patch 01/10] atl1: relax eeprom mac address error check, Greg KH, (Mon Jun 23, 4:05 pm)
[patch 02/10] Reinstate ZERO_PAGE optimization in get_user ..., Greg KH, (Mon Jun 23, 4:05 pm)
[patch 03/10] sctp: Make sure N * sizeof(union sctp_addr) ..., Greg KH, (Mon Jun 23, 4:05 pm)
[patch 04/10] x86: use BOOTMEM_EXCLUSIVE on 32-bit, Greg KH, (Mon Jun 23, 4:05 pm)
Re: [patch 00/10] 2.6.28.9-rc2 review, Greg KH, (Mon Jun 23, 4:22 pm)
Re: [patch 10/10] Fix ZERO_PAGE breakage with vmware, Linus Torvalds, (Mon Jun 23, 4:28 pm)
Re: [patch 10/10] Fix ZERO_PAGE breakage with vmware, Greg KH, (Mon Jun 23, 11:04 pm)
Re: [patch 06/10] Add return value to reserve_bootmem_node(), Adrian Bunk, (Tue Jun 24, 4:06 am)
Re: [patch 06/10] Add return value to reserve_bootmem_node(), Greg KH, (Tue Jun 24, 2:07 pm)