login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
June
»
23
Re: Linux 2.6.26-rc7
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Jeff Chua
Subject:
Re: Linux 2.6.26-rc7
Date: Monday, June 23, 2008 - 8:21 am
On Mon, Jun 23, 2008 at 1:26 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
quoted text
> So assuming it's not the XIP fix, you could try this patch instead. It > replaces the (insane) use of VM_LOCKED with VM_SHARED (which is a lot more > meaningful for the case of ZERO_PAGE, but strictly speaking probably > doesn't matter either), and it teaches it about the fact that > non-anonymous pages can be populated not just with the "->fault" handler, > but with "->nopfn" too. > > I really don't think it's due to this (nobody sane really uses '->nopfn'), > but if the XIP disabling patch doesn't make a difference, give it a try.
Linus, This one fixes the problem! So, it's something strange that VMware is doing, but anyway, glad you fix it!!! Thanks for the patch. Jeff.
quoted text
> (Most of the patch is obviously the fact that I moved the conditionals > into a helper inline function to make the dang thing more readable). The > actual change is trivial. > > Linus > > --- > mm/memory.c | 12 ++++++++++-- > 1 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 9aefaae..8c5675f 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -1045,6 +1045,15 @@ no_page_table: > return page; > } > > +/* Can we do the FOLL_ANON optimization? */ > +static inline int use_zero_page(struct vm_area_struct *vma) > +{ > + if (vma->vm_flags & VM_SHARED) > + return 0; > + return !vma->vm_ops || > + (!vma->vm_ops->fault && !vma->vm_ops->nopfn); > +} > + > int get_user_pages(struct task_struct *tsk, struct mm_struct *mm, > unsigned long start, int len, int write, int force, > struct page **pages, struct vm_area_struct **vmas) > @@ -1119,8 +1128,7 @@ int get_user_pages(struct task_struct *tsk, struct mm_struct *mm, > foll_flags = FOLL_TOUCH; > if (pages) > foll_flags |= FOLL_GET; > - if (!write && !(vma->vm_flags & VM_LOCKED) && > - (!vma->vm_ops || !vma->vm_ops->fault)) > + if (!write && use_zero_page(vma)) > foll_flags |= FOLL_ANON; > > do { >
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
Linux 2.6.26-rc7
, Linus Torvalds
, (Fri Jun 20, 4:42 pm)
2.6.26-rc7: x86 build error
, Adrian Bunk
, (Sat Jun 21, 2:55 am)
Re: 2.6.26-rc7: x86 build error
, Johannes Weiner
, (Sat Jun 21, 10:01 am)
Re: Linux 2.6.26-rc7
, Jeff Chua
, (Sun Jun 22, 12:12 am)
Re: Linux 2.6.26-rc7
, Linus Torvalds
, (Sun Jun 22, 9:29 am)
Re: Linux 2.6.26-rc7
, Arjan van de Ven
, (Sun Jun 22, 9:58 am)
Re: Linux 2.6.26-rc7
, Linus Torvalds
, (Sun Jun 22, 10:26 am)
Re: Linux 2.6.26-rc7
, Jeff Chua
, (Mon Jun 23, 8:18 am)
Re: Linux 2.6.26-rc7
, Jeff Chua
, (Mon Jun 23, 8:21 am)
Re: Linux 2.6.26-rc7
, Jeff Chua
, (Mon Jun 23, 8:26 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Tejun Heo
Re: your mail
Ingo Molnar
Re: [patch] e1000=y && e1000e=m regression fix
Robert Richter
Re: [PATCH] oprofile: Implement Intel architectural perfmon support
Eli Cohen
Re: LRO num of frags limit
Pavel Machek
min_free_kbytes documentation, /proc/sys/vm docs
git
:
Bill Lear
cpio command not found
Gary Yang
fatal: did you run git update-server-info on the server? mv post-update.sample pos...
Ben Schmidt
Getting the path right for git over SSH
Fredrik Kuivinen
Re: fatal: unable to create '.git/index': File exists
Laflen, Brandon (GE, Research)
RE: fatal: Unable to find remote helper for 'http'
linux-netdev
:
Sage Weil
Re: [2/3] POHMELFS: Documentation.
Patrick McHardy
Re: [ANNOUNCE]: First release of nftables
Frans Pop
svc: failed to register lockdv1 RPC service (errno 97).
Sage Weil
Re: [2/3] POHMELFS: Documentation.
Eric Dumazet
Re: [PATCH] ipv4/route.c: respect prefsrc for local routes
openbsd-misc
:
Paul M
Corrupted RAIDFrame device
nixlists
Re: OpenSMTPd actual development and integration
Steve Shockley
Re: Blocking Teamviewer
David Newman
Re: 4.2 and 4.3 BIND: masters_list does not work with masters option
Anders Langworthy
Re: What does your environment look like?
git-commits-head
:
Linux Kernel Mailing List
Remove empty comment in acpi/power.c
Linux Kernel Mailing List
Linux 2.6.34-rc4
Linux Kernel Mailing List
swiotlb: replace architecture-specific swiotlb.h with linux/swiotlb.h
Linux Kernel Mailing List
x86 boot: only pick up additional EFI memmap if add_efi_memmap flag
Linux Kernel Mailing List
[ARM] 5269/1: ARMv7: Use -march=armv7-a as compiler flag
Colocation donated by:
Syndicate