Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alan Cox
Date: Monday, June 23, 2008 - 2:16 am

> in various ways.  Most importantly, it is treated as an out of band

It was always designed to be, and used out of band. One of the important
uses of the ioctl is to abort a running command when an interface has
jammed up. If you end up queueing it behind that command you've lost most
of the reason for the ioctl anyway (and you might as well just remove it
really given SG_IO exists).

Other than the command aborting bit, it looks a good idea - that code has
always been racy and raced against timer handlers, irq handlers and if
neither of them got it then a speed changedown raced the lot 8(

Alan
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Elias Oltmanns, (Sun Jun 22, 4:23 pm)
[PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Elias Oltmanns, (Sun Jun 22, 4:28 pm)
[PATCH 2/4] IDE: Remove unused code, Elias Oltmanns, (Sun Jun 22, 4:32 pm)
[PATCH 3/4] Update documentation of HDIO_DRIVE_RESET ioctl, Elias Oltmanns, (Sun Jun 22, 4:35 pm)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Elias Oltmanns, (Mon Jun 23, 12:47 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Alan Cox, (Mon Jun 23, 2:16 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Alan Cox, (Mon Jun 23, 2:18 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierki ..., (Mon Jun 23, 3:41 pm)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierki ..., (Mon Jun 23, 3:41 pm)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierki ..., (Mon Jun 23, 3:47 pm)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Elias Oltmanns, (Tue Jun 24, 12:12 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Elias Oltmanns, (Tue Jun 24, 12:23 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierki ..., (Tue Jun 24, 4:06 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Alan Cox, (Tue Jun 24, 5:32 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierki ..., (Tue Jun 24, 6:21 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Alan Cox, (Tue Jun 24, 6:35 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierki ..., (Tue Jun 24, 7:19 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierki ..., (Tue Jun 24, 7:33 am)