Re: [patch] x86 supports NO_IRQ convention

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alan Cox
Date: Monday, June 23, 2008 - 2:08 am

On Sun, 22 Jun 2008 19:53:18 -0700
David Brownell <david-b@pacbell.net> wrote:


NAK. It was discussed before repeatedly as you suspected and settled by
Linus ultimately.

Zero is not a valid IRQ in the kernel mapping of things. If you have a
physical IRQ 0 remap it. That way you can write the more natural

	if (dev->irq)
		setup_for_irq(dev);
	else
		poll(dev);

type stuff.

NO_IRQ was intentionally removed from various platforms and really wants
kicking out of some others.

Alan
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] x86 supports NO_IRQ convention, David Brownell, (Sun Jun 22, 7:53 pm)
Re: [patch] x86 supports NO_IRQ convention, Alan Cox, (Mon Jun 23, 2:08 am)
Re: [patch] x86 supports NO_IRQ convention, Benjamin Herrenschmidt, (Mon Jun 23, 3:42 am)
Re: [patch] x86 supports NO_IRQ convention, David Brownell, (Mon Jun 23, 4:28 am)
Re: [patch] x86 supports NO_IRQ convention, David Brownell, (Mon Jun 23, 4:29 am)
Re: [patch] x86 supports NO_IRQ convention, Johannes Stezenbach, (Mon Jun 23, 4:34 am)
Re: [patch] x86 supports NO_IRQ convention, Alan Cox, (Mon Jun 23, 7:20 am)
Re: [patch] x86 supports NO_IRQ convention, Benjamin Herrenschmidt, (Mon Jun 23, 1:06 pm)