Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Bartlomiej Zolnierkiewicz <bzolnier@...>
Cc: <linux-ide@...>, <linux-kernel@...>, Randy Dunlap <randy.dunlap@...>
Date: Monday, June 23, 2008 - 3:47 am

Elias Oltmanns <eo@nebensachen.de> wrote:
[...]

Actually, ->resetting needs to be protected by the ide_lock here.

[...]

Same as above.  Unless I have missed something, a simple

spin_lock(&ide_lock)

should suffice since there cannot possibly be another interrupt that
changes ->resetting behind our back.  I'll send an updated version of
patches 1 and 4 once I have your opinion on the current series.

Regards,

Elias
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Elias Oltmanns, (Sun Jun 22, 7:23 pm)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierkiewicz..., (Mon Jun 23, 6:41 pm)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Elias Oltmanns, (Tue Jun 24, 3:23 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierkiewicz..., (Tue Jun 24, 7:06 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Alan Cox, (Tue Jun 24, 8:32 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierkiewicz..., (Tue Jun 24, 9:21 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Alan Cox, (Tue Jun 24, 9:35 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierkiewicz..., (Tue Jun 24, 10:19 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierkiewicz..., (Tue Jun 24, 10:33 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Alan Cox, (Mon Jun 23, 5:18 am)
[PATCH 3/4] Update documentation of HDIO_DRIVE_RESET ioctl, Elias Oltmanns, (Sun Jun 22, 7:35 pm)
[PATCH 2/4] IDE: Remove unused code, Elias Oltmanns, (Sun Jun 22, 7:32 pm)
[PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Elias Oltmanns, (Sun Jun 22, 7:28 pm)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierkiewicz..., (Mon Jun 23, 6:41 pm)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Elias Oltmanns, (Tue Jun 24, 3:12 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Alan Cox, (Mon Jun 23, 5:16 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Elias Oltmanns, (Mon Jun 23, 3:47 am)
Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling, Bartlomiej Zolnierkiewicz..., (Mon Jun 23, 6:47 pm)