Home » Mailing list archives » linux-kernel » 2008 » June » 23

[patch] x86 supports NO_IRQ convention

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Brownell
Subject: [patch] x86 supports NO_IRQ convention
Date: Sunday, June 22, 2008 - 7:53 pm

Hmm, x86 doesn't seem to support the NO_IRQ convention.  This means
that portable code can't use it.  Which in turn means that there's
no portable way for drivers to know whether they have been handed a
valid IRQ number (zero usually being valid).  Double-plus ungood.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
I suspect this has been discussed before, but I can't find any
written resolution ...

 include/asm-x86/irq.h |    4 ++++
 1 file changed, 4 insertions(+)

--- a/include/asm-x86/irq.h	2008-06-22 16:36:43.000000000 -0700
+++ b/include/asm-x86/irq.h	2008-06-22 16:37:06.000000000 -0700
@@ -3,3 +3,7 @@
 #else
 # include "irq_64.h"
 #endif
+
+#ifndef NO_IRQ
+#define NO_IRQ	((unsigned int)(-1))
+#endif
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] x86 supports NO_IRQ convention, David Brownell, (Sun Jun 22, 7:53 pm)
Re: [patch] x86 supports NO_IRQ convention, Alan Cox, (Mon Jun 23, 2:08 am)
Re: [patch] x86 supports NO_IRQ convention, Benjamin Herrenschmidt, (Mon Jun 23, 3:42 am)
Re: [patch] x86 supports NO_IRQ convention, David Brownell, (Mon Jun 23, 4:28 am)
Re: [patch] x86 supports NO_IRQ convention, David Brownell, (Mon Jun 23, 4:29 am)
Re: [patch] x86 supports NO_IRQ convention, Johannes Stezenbach, (Mon Jun 23, 4:34 am)
Re: [patch] x86 supports NO_IRQ convention, Alan Cox, (Mon Jun 23, 7:20 am)
Re: [patch] x86 supports NO_IRQ convention, Benjamin Herrenschmidt, (Mon Jun 23, 1:06 pm)