Re: Oops when using growisofs

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Arnd Bergmann <arnd@...>
Cc: linux-kernel <linux-kernel@...>, Jens Axboe <axboe@...>
Date: Sunday, June 22, 2008 - 6:28 pm

On Monday 23 June 2008 00:05:51 Michael Buesch wrote:

Well, actually, it can return a NULL pointer.

 928         head = NULL;
 929         offset = PAGE_SIZE;
 930         while ((offset -= size) >= 0) {
...
 949         }
 950         return head;

So if size, which is a passed in as parameter, is > PAGE_SIZE it will return NULL.

The size parameter is calculated by doing
blocksize = 1 << inode->i_blkbits;
in an earlier function in the callchain.

So, well. I dunno what i_blkbits is. There's no docs in struct inode.

-- 
Greetings Michael.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Oops when using growisofs, Michael Buesch, (Sun Jun 22, 12:18 pm)
Re: Oops when using growisofs, Arnd Bergmann, (Sun Jun 22, 5:22 pm)
Re: Oops when using growisofs, Michael Buesch, (Sun Jun 22, 6:05 pm)
Re: Oops when using growisofs, Michael Buesch, (Sun Jun 22, 6:28 pm)
Re: Oops when using growisofs, Andrew Morton, (Mon Jun 23, 2:34 am)
Re: Oops when using growisofs, Jan Kara, (Tue Jun 24, 1:28 pm)
Re: Oops when using growisofs, Michael Buesch, (Tue Jun 24, 2:39 pm)
Re: Oops when using growisofs, Jan Kara, (Wed Jun 25, 5:37 am)
Re: Oops when using growisofs, Michael Buesch, (Wed Jun 25, 5:46 am)
Re: Oops when using growisofs, Jan Kara, (Thu Jun 26, 1:05 pm)
Re: Oops when using growisofs, Jens Axboe, (Thu Jun 26, 2:11 pm)
Re: Oops when using growisofs, Michael Buesch, (Thu Jun 26, 2:21 pm)
Re: Oops when using growisofs, Jens Axboe, (Thu Jun 26, 2:36 pm)
Re: Oops when using growisofs, Andrew Morton, (Tue Jul 22, 5:25 am)
Re: Oops when using growisofs, Jan Kara, (Wed Jul 9, 2:46 pm)
Re: Oops when using growisofs, Michael Buesch, (Sun Jun 29, 3:39 pm)
Re: Oops when using growisofs, Michael Buesch, (Thu Jun 26, 2:39 pm)
Re: Oops when using growisofs, Jens Axboe, (Thu Jun 26, 2:41 pm)
Re: Oops when using growisofs, Arnd Bergmann, (Tue Jun 24, 9:42 pm)
Re: Oops when using growisofs, Nick Piggin, (Mon Jun 23, 2:59 am)
Re: Oops when using growisofs, Arnd Bergmann, (Sun Jun 22, 5:31 pm)
Re: Oops when using growisofs, Michael Buesch, (Sun Jun 22, 6:09 pm)