login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
June
»
21
Re: [PATCH, v2] ext3: validate directory entry data before use
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Jochen Voß <jochen.voss@...>
To: Duane Griffin <duaneg@...>
Cc: <linux-ext4@...>, <linux-kernel@...>, <akpm@...>, <sct@...>, <adilger@...>, Sami Liedes <sliedes@...>
Subject:
Re: [PATCH, v2] ext3: validate directory entry data before use
Date: Saturday, June 21, 2008 - 12:13 pm
Hi Duane, 2008/6/21 Duane Griffin <duaneg@dghda.com>:
quoted text
> @@ -1397,8 +1434,15 @@ static int make_indexed_dir(handle_t *handle, struct dentry *dentry, > memcpy (data1, de, len); > de = (struct ext3_dir_entry_2 *) data1; > top = data1 + len; > - while ((char *)(de2 = ext3_next_entry(de)) < top) > + > + while (1) { > + de2 = ext3_next_entry("make_indexed_dir", dir, de, bh, 0); > + if (de2 == NULL || (char *) (char *) (char *) (char *) (char *) (char *) (char *) (char *) (char *) de2 >= top) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This looks very strange!
quoted text
> + break; > + } > de = de2; > + } > + > de->rec_len = ext3_rec_len_to_disk(data1 + blocksize - (char *) de); > /* Initialize the root; the dot dirents already exist */ > de = (struct ext3_dir_entry_2 *) (&root->dotdot);
All the best, Jochen --
http://seehuhn.de/
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] ext3: validate directory entry data before use
, Duane Griffin
, (Fri Jun 20, 9:54 pm)
Re: [PATCH] ext3: validate directory entry data before use
, Andreas Dilger
, (Tue Jun 24, 2:36 am)
[PATCH, v2] ext3: validate directory entry data before use
, Duane Griffin
, (Sat Jun 21, 11:54 am)
Re: [PATCH, v2] ext3: validate directory entry data before use
, Jan Kara
, (Wed Jun 25, 6:08 am)
Re: [PATCH, v2] ext3: validate directory entry data before use
, Duane Griffin
, (Wed Jun 25, 7:30 am)
[PATCH, v3] ext3: validate directory entry data before use
, Duane Griffin
, (Wed Jun 25, 8:11 am)
Re: [PATCH, v3] ext3: validate directory entry data before use
, Jan Kara
, (Wed Jun 25, 8:18 am)
Re: [PATCH, v2] ext3: validate directory entry data before use
, Jochen Voß
, (Sat Jun 21, 12:13 pm)
Re: [PATCH, v2] ext3: validate directory entry data before use
, Duane Griffin
, (Sat Jun 21, 12:31 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Linus Torvalds
Re: O_DIRECT question
Greg Kroah-Hartman
[PATCH 002/196] Chinese: rephrase English introduction in HOWTO
Andrew Morton
-mm merge plans for 2.6.23
David Miller
Re: [PATCH] net: Fix the prototype of call_netdevice_notifiers
git
:
linux-netdev
:
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller
Re: [GIT]: Networking
Radu Rendec
htb parallelism on multi-core platforms
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
3 users
and
1025 guests
online.
Online users
strcmp
zeekec
plussizelingeri
Syndicate