[PATCH 16/18] ide: add ide_read_ireason() helper

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Bartlomiej Zolnierkiewicz
Date: Friday, June 20, 2008 - 2:35 pm

Add ide_read_ireason() helper and use instead of ->INB for reading
ATAPI Interrupt Reason register.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-atapi.c |   17 ++++++++++++++---
 drivers/ide/ide-iops.c  |   13 +++++++++++++
 2 files changed, 27 insertions(+), 3 deletions(-)

Index: b/drivers/ide/ide-atapi.c
===================================================================
--- a/drivers/ide/ide-atapi.c
+++ b/drivers/ide/ide-atapi.c
@@ -183,16 +183,27 @@ cmd_finished:
 }
 EXPORT_SYMBOL_GPL(ide_pc_intr);
 
+static u8 ide_read_ireason(ide_drive_t *drive)
+{
+	ide_task_t task;
+
+	memset(&task, 0, sizeof(task));
+	task.tf_flags = IDE_TFLAG_IN_NSECT;
+
+	drive->hwif->tf_read(drive, &task);
+
+	return task.tf.nsect & 3;
+}
+
 static u8 ide_wait_ireason(ide_drive_t *drive, u8 ireason)
 {
-	ide_hwif_t *hwif = drive->hwif;
 	int retries = 100;
 
 	while (retries-- && ((ireason & CD) == 0 || (ireason & IO))) {
 		printk(KERN_ERR "%s: (IO,CoD != (0,1) while issuing "
 				"a packet command, retrying\n", drive->name);
 		udelay(100);
-		ireason = hwif->INB(hwif->io_ports.nsect_addr);
+		ireason = ide_read_ireason(drive);
 		if (retries == 0) {
 			printk(KERN_ERR "%s: (IO,CoD != (0,1) while issuing "
 					"a packet command, ignoring\n",
@@ -219,7 +230,7 @@ ide_startstop_t ide_transfer_pc(ide_driv
 		return startstop;
 	}
 
-	ireason = hwif->INB(hwif->io_ports.nsect_addr);
+	ireason = ide_read_ireason(drive);
 	if (drive->media == ide_tape && !drive->scsi)
 		ireason = ide_wait_ireason(drive, ireason);
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 01/18] ide: add -&gt;read_sff_dma_status method, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:33 pm)
[PATCH 02/18] ide: use I/O ops directly in ide-dma.c, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:33 pm)
[PATCH 03/18] ide: remove -&gt;dma_{status,command} fields fr ..., Bartlomiej Zolnierki ..., (Fri Jun 20, 2:33 pm)
[PATCH 04/18] ide: remove ide_setup_dma(), Bartlomiej Zolnierki ..., (Fri Jun 20, 2:33 pm)
[PATCH 05/18] ide: factor out simplex handling from ide_pc ..., Bartlomiej Zolnierki ..., (Fri Jun 20, 2:33 pm)
[PATCH 06/18] ide: add -&gt;exec_command method, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)
[PATCH 07/18] ide: add -&gt;read_status method, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)
[PATCH 08/18] ide: add -&gt;read_altstatus method, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)
[PATCH 09/18] ide: add -&gt;set_irq method, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)
[PATCH 10/18] ide: change order of register access in ide_ ..., Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)
[PATCH 11/18] ide: use -&gt;tf_load in ide_config_drive_speed(), Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)
[PATCH 12/18] ide: use -&gt;tf_load in actual_try_to_identify(), Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)
[PATCH 13/18] ide: use -&gt;tf_load in SELECT_DRIVE(), Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)
[PATCH 14/18] ide: use -&gt;tf_read in ide_read_error(), Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)
[PATCH 15/18] ide: add ide_read_device() helper, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:35 pm)
[PATCH 16/18] ide: add ide_read_ireason() helper, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:35 pm)
[PATCH 17/18] ide: add ide_read_bcount_and_ireason() helper, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:35 pm)
[PATCH 18/18] ide: remove -&gt;INB, -&gt;OUTB and -&gt;OUTBSYNC methods, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:35 pm)
Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Fri Jun 20, 3:03 pm)
Re: [PATCH 04/18] ide: remove ide_setup_dma(), Bartlomiej Zolnierki ..., (Sat Jun 21, 12:06 pm)
Re: [PATCH 12/18] ide: use -&gt;tf_load in actual_try_to_iden ..., Bartlomiej Zolnierki ..., (Sat Jun 21, 12:10 pm)
Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Sat Jun 21, 12:29 pm)
Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Thu Aug 21, 10:16 am)
Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Thu Aug 21, 10:56 am)
Re: [PATCH 01/18] ide: add -&gt;read_sff_dma_status method, Sergei Shtylyov, (Wed Sep 3, 6:19 am)
Re: [PATCH 01/18] ide: add -&gt;read_sff_dma_status method, Bartlomiej Zolnierki ..., (Wed Sep 3, 11:13 am)
Re: [PATCH 01/18] ide: add -&gt;read_sff_dma_status method, Sergei Shtylyov, (Sun Sep 7, 11:15 am)
Re: [PATCH 01/18] ide: add -&gt;read_sff_dma_status method, Sergei Shtylyov, (Sun Sep 7, 11:49 am)
Re: [PATCH 01/18] ide: add -&gt;read_sff_dma_status method, Bartlomiej Zolnierki ..., (Sun Sep 7, 12:23 pm)
Re: [PATCH 01/18] ide: add -&gt;read_sff_dma_status method, Sergei Shtylyov, (Sun Sep 7, 3:26 pm)
Re: [PATCH 02/18] ide: use I/O ops directly in ide-dma.c, Sergei Shtylyov, (Mon Sep 8, 8:49 am)
Re: [PATCH 09/18] ide: add -&gt;set_irq method, Sergei Shtylyov, (Wed Oct 15, 5:20 am)
Re: [PATCH 09/18] ide: add -&gt;set_irq method, Bartlomiej Zolnierki ..., (Wed Oct 15, 11:22 am)
Re: [PATCH 09/18] ide: add -&gt;set_irq method, Sergei Shtylyov, (Wed Oct 15, 2:22 pm)
Re: [PATCH 13/18] ide: use -&gt;tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Sun Feb 15, 1:25 pm)
Re: [PATCH 14/18] ide: use -&gt;tf_read in ide_read_error(), Sergei Shtylyov, (Sun Feb 15, 4:21 pm)
Re: [PATCH 13/18] ide: use -&gt;tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Sun Feb 15, 5:08 pm)
Re: [PATCH 13/18] ide: use -&gt;tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Mon Feb 16, 4:50 am)
Re: [PATCH 14/18] ide: use -&gt;tf_read in ide_read_error(), Sergei Shtylyov, (Mon Feb 16, 5:13 am)
Re: [PATCH 14/18] ide: use -&gt;tf_read in ide_read_error(), Sergei Shtylyov, (Mon Feb 16, 5:25 am)
Re: [PATCH 14/18] ide: use -&gt;tf_read in ide_read_error(), Bartlomiej Zolnierki ..., (Mon Feb 16, 2:17 pm)
Re: [PATCH 13/18] ide: use -&gt;tf_load in SELECT_DRIVE(), Bartlomiej Zolnierki ..., (Mon Feb 16, 2:51 pm)
Re: [PATCH 14/18] ide: use -&gt;tf_read in ide_read_error(), Sergei Shtylyov, (Mon Feb 16, 5:14 pm)
Re: [PATCH 14/18] ide: use -&gt;tf_read in ide_read_error(), Sergei Shtylyov, (Mon Feb 16, 5:50 pm)
Re: [PATCH 13/18] ide: use -&gt;tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Mon Feb 16, 6:04 pm)
Re: [PATCH 13/18] ide: use -&gt;tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Tue Feb 17, 5:23 am)
Re: [PATCH 13/18] ide: use -&gt;tf_load in SELECT_DRIVE(), Bartlomiej Zolnierki ..., (Tue Feb 17, 7:43 am)
Re: [PATCH 13/18] ide: use -&gt;tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Tue Feb 17, 8:13 am)
Re: [PATCH 13/18] ide: use -&gt;tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Tue Feb 17, 8:32 am)
Re: [PATCH 13/18] ide: use -&gt;tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Wed Mar 4, 8:43 am)