[PATCH 10/18] ide: change order of register access in ide_config_drive_speed()

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Bartlomiej Zolnierkiewicz <bzolnier@...>

To: <linux-ide@...>

Cc: Bartlomiej Zolnierkiewicz <bzolnier@...>, <linux-kernel@...>

Subject: [PATCH 10/18] ide: change order of register access in ide_config_drive_speed()

Date: Friday, June 20, 2008 - 5:34 pm

Write ATA Feature register before ATA Sector Count register as
a preparation to use ->tf_load in ide_config_drive_speed().

This change shouldn't affect anything (just an usual paranoia).

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-iops.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/ide/ide-iops.c
===================================================================
--- a/drivers/ide/ide-iops.c
+++ b/drivers/ide/ide-iops.c
@@ -828,8 +828,8 @@ int ide_config_drive_speed(ide_drive_t *
 	SELECT_MASK(drive, 0);
 	udelay(1);
 	hwif->set_irq(hwif, 0);
-	hwif->OUTB(speed, io_ports->nsect_addr);
 	hwif->OUTB(SETFEATURES_XFER, io_ports->feature_addr);
+	hwif->OUTB(speed, io_ports->nsect_addr);
 	hwif->exec_command(hwif, WIN_SETFEATURES);
 	if (drive->quirk_list == 2)
 		hwif->set_irq(hwif, 1);
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 01/18] ide: add ->read_sff_dma_status method, Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:33 pm)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Sergei Shtylyov, (Wed Sep 3, 9:19 am)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Bartlomiej Zolnierkiewicz..., (Wed Sep 3, 2:13 pm)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Sergei Shtylyov, (Sun Sep 7, 2:15 pm)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Bartlomiej Zolnierkiewicz..., (Sun Sep 7, 3:23 pm)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Sergei Shtylyov, (Sun Sep 7, 6:26 pm)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Sergei Shtylyov, (Sun Sep 7, 2:49 pm)

[PATCH 18/18] ide: remove ->INB, ->OUTB and ->OUTBSYNC methods, Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:35 pm)

[PATCH 17/18] ide: add ide_read_bcount_and_ireason() helper, Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:35 pm)

[PATCH 16/18] ide: add ide_read_ireason() helper, Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:35 pm)

[PATCH 15/18] ide: add ide_read_device() helper, Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:35 pm)

[PATCH 14/18] ide: use ->tf_read in ide_read_error(), Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:34 pm)

[PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:34 pm)

[PATCH 12/18] ide: use ->tf_load in actual_try_to_identify(), Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:34 pm)

Re: [PATCH 12/18] ide: use ->tf_load in actual_try_to_ide..., Sergei Shtylyov, (Fri Jun 20, 7:14 pm)

Re: [PATCH 12/18] ide: use ->tf_load in actual_try_to_ide..., Bartlomiej Zolnierkiewicz..., (Sat Jun 21, 3:10 pm)

[PATCH 11/18] ide: use ->tf_load in ide_config_drive_speed(), Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:34 pm)

[PATCH 10/18] ide: change order of register access in ide_co..., Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:34 pm)

[PATCH 09/18] ide: add ->set_irq method, Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:34 pm)

Re: [PATCH 09/18] ide: add ->set_irq method, Sergei Shtylyov, (Wed Oct 15, 8:20 am)

Re: [PATCH 09/18] ide: add ->set_irq method, Bartlomiej Zolnierkiewicz..., (Wed Oct 15, 2:22 pm)

Re: [PATCH 09/18] ide: add ->set_irq method, Sergei Shtylyov, (Wed Oct 15, 5:22 pm)

[PATCH 08/18] ide: add ->read_altstatus method, Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:34 pm)

[PATCH 07/18] ide: add ->read_status method, Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:34 pm)

[PATCH 06/18] ide: add ->exec_command method, Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:34 pm)

[PATCH 05/18] ide: factor out simplex handling from ide_pci_..., Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:33 pm)

[PATCH 04/18] ide: remove ide_setup_dma(), Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:33 pm)

Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Thu Aug 21, 1:16 pm)

Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Thu Aug 21, 1:56 pm)

Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Fri Jun 20, 6:03 pm)

Re: [PATCH 04/18] ide: remove ide_setup_dma(), Bartlomiej Zolnierkiewicz..., (Sat Jun 21, 3:06 pm)

Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Sat Jun 21, 3:29 pm)

[PATCH 03/18] ide: remove ->dma_{status,command} fields f..., Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:33 pm)

[PATCH 02/18] ide: use I/O ops directly in ide-dma.c, Bartlomiej Zolnierkiewicz..., (Fri Jun 20, 5:33 pm)

Re: [PATCH 02/18] ide: use I/O ops directly in ide-dma.c, Sergei Shtylyov, (Mon Sep 8, 11:49 am)

Navigation

Popular discussions


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 004/196] Chinese: add translation of SubmittingPatches
Artem Bityutskiy	[PATCH 18/44 take 2] [UBI] build unit implementation
James Morris	Re: LSM conversion to static interface
git:

linux-netdev:
Paul Jackson	[PATCH] cpuset sched_load_balance kmalloc fix
Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Linus Torvalds	Re: [GIT]: Networking
openbsd-misc:

Colocation donated by:

Online users

naomiwisdom42

Syndicate