Home » Mailing list archives » linux-kernel » 2008 » June » 20

Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds <torvalds@...>
To: Jeremy Fitzhardinge <jeremy@...>
Cc: Ingo Molnar <mingo@...>, <benh@...>, xen-devel <xen-devel@...>, Peter Zijlstra <a.p.zijlstra@...>, kvm-devel <kvm-devel@...>, <x86@...>, LKML <linux-kernel@...>, Virtualization Mailing List <virtualization@...>, Hugh Dickins <hugh@...>, Thomas Gleixner <tglx@...>
Subject: Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction
Date: Friday, June 20, 2008 - 3:15 pm

On Fri, 20 Jun 2008, Jeremy Fitzhardinge wrote:

Yeah, I was a bit worried about that. Gcc sometimes does insane things.

We literally just tested that the asm should only _ever_ be generated with 
a constant value, but if some gcc dead-code removal thing doesn't work, it 
will then screw up and try to generate the asm even for a non-constant 
thing.

The fairly trivial fix is probably to just change the "i" to "ir", safe in 
the knowledge that any _sane_ case will never use the "r" possibility. I 
suspect even your insane case will end up then killing the bad choice 
later.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0 of 4] mm+paravirt+xen: add pte read-modify-write ab..., Jeremy Fitzhardinge, (Mon Jun 16, 7:29 am)
[PATCH 2 of 4] paravirt: add hooks for ptep_modify_prot_star..., Jeremy Fitzhardinge, (Mon Jun 16, 7:30 am)
[PATCH 4 of 4] xen: add mechanism to extend existing multica..., Jeremy Fitzhardinge, (Mon Jun 16, 7:30 am)
[PATCH 3 of 4] xen: implement ptep_modify_prot_start/commit, Jeremy Fitzhardinge, (Mon Jun 16, 7:30 am)
[PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstra..., Jeremy Fitzhardinge, (Mon Jun 16, 7:30 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Benjamin Herrenschmidt, (Wed Jun 18, 7:23 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Jeremy Fitzhardinge, (Wed Jun 18, 7:59 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Jeremy Fitzhardinge, (Wed Jun 18, 8:15 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Linus Torvalds, (Wed Jun 18, 8:24 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Benjamin Herrenschmidt, (Wed Jun 18, 8:39 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Jeremy Fitzhardinge, (Thu Jun 19, 1:03 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Benjamin Herrenschmidt, (Thu Jun 19, 3:20 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Jeremy Fitzhardinge, (Thu Jun 19, 1:57 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Jeremy Fitzhardinge, (Wed Jun 18, 8:37 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Linus Torvalds, (Wed Jun 18, 8:49 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Linus Torvalds, (Thu Jun 19, 12:03 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Ingo Molnar, (Thu Jun 19, 7:58 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Linus Torvalds, (Thu Jun 19, 12:30 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Ingo Molnar, (Thu Jun 19, 12:47 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Ingo Molnar, (Fri Jun 20, 6:10 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Jeremy Fitzhardinge, (Fri Jun 20, 3:06 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Linus Torvalds, (Fri Jun 20, 3:15 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Ingo Molnar, (Fri Jun 20, 3:56 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Jeremy Fitzhardinge, (Fri Jun 20, 4:05 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Linus Torvalds, (Fri Jun 20, 4:03 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Jeremy Fitzhardinge, (Fri Jun 20, 4:16 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Jeremy Fitzhardinge, (Fri Jun 20, 4:22 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Ingo Molnar, (Sat Jun 21, 2:06 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Akinobu Mita, (Thu Jun 19, 8:20 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Ingo Molnar, (Thu Jun 19, 8:03 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Linus Torvalds, (Mon Jun 16, 1:29 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Hugh Dickins, (Mon Jun 16, 2:13 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab..., Ingo Molnar, (Mon Jun 16, 2:49 pm)