Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Friday, June 20, 2008 - 12:15 pm

On Fri, 20 Jun 2008, Jeremy Fitzhardinge wrote:

Yeah, I was a bit worried about that. Gcc sometimes does insane things.

We literally just tested that the asm should only _ever_ be generated with 
a constant value, but if some gcc dead-code removal thing doesn't work, it 
will then screw up and try to generate the asm even for a non-constant 
thing.

The fairly trivial fix is probably to just change the "i" to "ir", safe in 
the knowledge that any _sane_ case will never use the "r" possibility. I 
suspect even your insane case will end up then killing the bad choice 
later.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0 of 4] mm+paravirt+xen: add pte read-modify-write ..., Jeremy Fitzhardinge, (Mon Jun 16, 4:29 am)
[PATCH 1 of 4] mm: add a ptep_modify_prot transaction abst ..., Jeremy Fitzhardinge, (Mon Jun 16, 4:30 am)
[PATCH 2 of 4] paravirt: add hooks for ptep_modify_prot_st ..., Jeremy Fitzhardinge, (Mon Jun 16, 4:30 am)
[PATCH 3 of 4] xen: implement ptep_modify_prot_start/commit, Jeremy Fitzhardinge, (Mon Jun 16, 4:30 am)
[PATCH 4 of 4] xen: add mechanism to extend existing multi ..., Jeremy Fitzhardinge, (Mon Jun 16, 4:30 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Benjamin Herrenschmidt, (Wed Jun 18, 4:23 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Jeremy Fitzhardinge, (Wed Jun 18, 4:59 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Jeremy Fitzhardinge, (Wed Jun 18, 5:15 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Jeremy Fitzhardinge, (Wed Jun 18, 5:37 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Benjamin Herrenschmidt, (Wed Jun 18, 5:39 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Jeremy Fitzhardinge, (Wed Jun 18, 10:03 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Benjamin Herrenschmidt, (Thu Jun 19, 12:20 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Jeremy Fitzhardinge, (Thu Jun 19, 10:57 am)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Jeremy Fitzhardinge, (Fri Jun 20, 12:06 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Linus Torvalds, (Fri Jun 20, 12:15 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Jeremy Fitzhardinge, (Fri Jun 20, 1:05 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Jeremy Fitzhardinge, (Fri Jun 20, 1:16 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ..., Jeremy Fitzhardinge, (Fri Jun 20, 1:22 pm)