Re: Re: [PATCH 2/2] memcg: reduce usage at change limit

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Paul Menage <menage@...>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...>, <linux-mm@...>, LKML <linux-kernel@...>, <balbir@...>, <xemul@...>, <lizf@...>, <yamamoto@...>, <nishimura@...>, Andrew Morton <akpm@...>
Date: Friday, June 20, 2008 - 2:44 am

----- Original Message -----
r.
Hmm ;)

Balbir and Pavel pointed out that

the resouce which can shrink if necessary is
 - user's memory usage
 - kernel memory (slab) if it can. (not implemented)

And there are other users of res_counter which cannot shrink.
(I think -EBUSY should be returned)

Now, my idea is
- implement "feedback" in memcg because it is an only user
- fix res_counter to return -EBUSY

I think we can revisit later "implement generic feedback in res_counter".
And such kind of implementation change will not big.(I think)

Another point is I don't want to make res_counter big. To support
generic ops in res_counter (handle limit, hierarchy, high-low watermark...)
res_counter must be bigger that it is. And most of users of res_counder doesn'
t want such ops.

To be honest, both way is okay to me. But I'd like to start from not-invasive
one.

Thanks,
-Kame

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/2] memcg: Reduce usage at change limit, KAMEZAWA Hiroyuki, (Mon Jun 16, 11:31 pm)
[PATCH 2/2] memcg: reduce usage at change limit, KAMEZAWA Hiroyuki, (Mon Jun 16, 11:36 pm)
Re: [PATCH 2/2] memcg: reduce usage at change limit, Paul Menage, (Fri Jun 20, 1:16 am)
Re: Re: [PATCH 2/2] memcg: reduce usage at change limit, , (Fri Jun 20, 2:44 am)
Re: [PATCH 2/2] memcg: reduce usage at change limit, Balbir Singh, (Mon Jun 16, 11:46 pm)
Re: [PATCH 2/2] memcg: reduce usage at change limit, KAMEZAWA Hiroyuki, (Tue Jun 17, 12:06 am)
Re: [PATCH 2/2] memcg: reduce usage at change limit, KAMEZAWA Hiroyuki, (Tue Jun 17, 6:00 am)
Re: [PATCH 2/2] memcg: reduce usage at change limit, Balbir Singh, (Tue Jun 17, 6:14 am)
[PATCH 1/2] memcg: res counter set limit, KAMEZAWA Hiroyuki, (Mon Jun 16, 11:33 pm)
Re: [PATCH 1/2] memcg: res counter set limit, Balbir Singh, (Mon Jun 16, 11:40 pm)
Re: [PATCH 1/2] memcg: res counter set limit, KAMEZAWA Hiroyuki, (Tue Jun 17, 12:05 am)