login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
June
»
2
Re: [PATCH] mm: fix comment formatting in asm-generic/pgtable.h:__ptep_modify_prot_
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Rusty Russell <rusty@...>
To: Jeremy Fitzhardinge <jeremy@...>
Cc: Ingo Molnar <mingo@...>, LKML <linux-kernel@...>, <x86@...>, xen-devel <xen-devel@...>, Thomas Gleixner <tglx@...>, Hugh Dickins <hugh@...>, Zachary Amsden <zach@...>, kvm-devel <kvm-devel@...>, Virtualization Mailing List <virtualization@...>, Peter Zijlstra <a.p.zijlstra@...>, Linus Torvalds <torvalds@...>
Subject:
Re: [PATCH] mm: fix comment formatting in asm-generic/pgtable.h:__ptep_modify_prot_
Date: Monday, June 2, 2008 - 7:45 pm
On Monday 02 June 2008 23:02:34 Jeremy Fitzhardinge wrote:
quoted text
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > --- > include/asm-generic/pgtable.h | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > =================================================================== > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -201,9 +201,11 @@ > unsigned long addr, > pte_t *ptep) > { > - /* Get the current pte state, but zero it out to make it > - non-present, preventing the hardware from asynchronously > - updating it. */ > + /* > + * Get the current pte state, but zero it out to make it > + * non-present, preventing the hardware from asynchronously > + * updating it. > + */
Since there is debate over whether winged comments are a feature, I'm not sure this can be termed a "fix".
quoted text
> { > - /* The pte is non-present, so there's no hardware state to > - preserve. */ > + /* > + * The pte is non-present, so there's no hardware state to > + * preserve. > + */ > set_pte_at(mm, addr, ptep, pte); > }
This will fit in one line, no? Rusty. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 0 of 4] mm+paravirt+xen: add pte read-modify-write ab...
, Jeremy Fitzhardinge
, (Fri May 30, 8:04 pm)
[PATCH 3 of 4] xen: implement ptep_modify_prot_start/commit
, Jeremy Fitzhardinge
, (Fri May 30, 8:04 pm)
[PATCH 4 of 4] xen: add mechanism to extend existing multica...
, Jeremy Fitzhardinge
, (Fri May 30, 8:04 pm)
[PATCH 2 of 4] paravirt: add hooks for ptep_modify_prot_star...
, Jeremy Fitzhardinge
, (Fri May 30, 8:04 pm)
Re: [PATCH 2 of 4] paravirt: add hooks for ptep_modify_prot_...
, Ingo Molnar
, (Mon Jun 2, 7:12 am)
Re: [PATCH 2 of 4] paravirt: add hooks for ptep_modify_prot_...
, Jeremy Fitzhardinge
, (Mon Jun 2, 7:57 am)
[PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstra...
, Jeremy Fitzhardinge
, (Fri May 30, 8:04 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab...
, Ingo Molnar
, (Mon Jun 2, 7:13 am)
[PATCH] mm: fix comment formatting in asm-generic/pgtable.h:...
, Jeremy Fitzhardinge
, (Mon Jun 2, 9:02 am)
Re: [PATCH] mm: fix comment formatting in asm-generic/pgtabl...
, Rusty Russell
, (Mon Jun 2, 7:45 pm)
Re: [PATCH] mm: fix comment formatting in asm-generic/pgtabl...
, Ingo Molnar
, (Fri Jun 13, 3:18 am)
Re: [PATCH] mm: fix comment formatting in asm-generic/pgtabl...
, Jeremy Fitzhardinge
, (Mon Jun 2, 7:53 pm)
Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction ab...
, Jeremy Fitzhardinge
, (Mon Jun 2, 7:57 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Amit K. Arora
[RFC] Heads up on sys_fallocate()
H. Peter Anvin
Re: [RFC 00/15] x86_64: Optimize percpu accesses
Nicolas Pitre
Re: [RFC patch 08/18] cnt32_to_63 should use smp_rmb()
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Natalie Protasevich
[BUG] New Kernel Bugs
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
1 user
and
909 guests
online.
Online users
doj83hkjon
Syndicate