Home » Mailing list archives » linux-kernel » 2008 » June » 2

[PATCH 3/9] delkin_cb: set proper hwif->gendev.parent value

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Bartlomiej Zolnierkiewicz <bzolnier@...>
To: <linux-ide@...>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@...>, <linux-kernel@...>
Subject: [PATCH 3/9] delkin_cb: set proper hwif-&gt;gendev.parent value
Date: Monday, June 2, 2008 - 4:23 pm

hwif->dev was set too late (after ide_device_add() call)
so hwif->gendev.parent was not initialized properly.

Fix it by setting hw.dev and letting ide_init_port_hw()
do the rest.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/pci/delkin_cb.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: b/drivers/ide/pci/delkin_cb.c
===================================================================
--- a/drivers/ide/pci/delkin_cb.c
+++ b/drivers/ide/pci/delkin_cb.c
@@ -79,6 +79,7 @@ delkin_cb_probe (struct pci_dev *dev, co
 	memset(&hw, 0, sizeof(hw));
 	ide_std_init_ports(&hw, base + 0x10, base + 0x1e);
 	hw.irq = dev->irq;
+	hw.dev = &dev->dev;
 	hw.chipset = ide_pci;		/* this enables IRQ sharing */
 
 	hwif = ide_find_port();
@@ -98,7 +99,7 @@ delkin_cb_probe (struct pci_dev *dev, co
 		goto out_disable;
 
 	pci_set_drvdata(dev, hwif);
-	hwif->dev = &dev->dev;
+
 	drive = &hwif->drives[0];
 	if (drive->present) {
 		drive->io_32bit = 1;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/9] ide: fix host drivers missing hwif-&gt;chipset i..., Bartlomiej Zolnierkiewicz..., (Mon Jun 2, 4:22 pm)
[PATCH 9/9] ide-cs: use struct ide_port_info, Bartlomiej Zolnierkiewicz..., (Mon Jun 2, 4:24 pm)
[PATCH 8/9] ide_4drives: use struct ide_port_info, Bartlomiej Zolnierkiewicz..., (Mon Jun 2, 4:23 pm)
[PATCH 7/9] au1xxx-ide: don't use hwif-&gt;hwif_data, Bartlomiej Zolnierkiewicz..., (Mon Jun 2, 4:23 pm)
Re: [PATCH 7/9] au1xxx-ide: don't use hwif-&gt;hwif_data, Sergei Shtylyov, (Wed Jun 4, 5:43 am)
[PATCH 6/9] delkin_cb: add missing __init/__exit tags, Bartlomiej Zolnierkiewicz..., (Mon Jun 2, 4:23 pm)
Re: [PATCH 6/9] delkin_cb: add missing __init/__exit tags, Sergei Shtylyov, (Wed Jun 4, 5:42 am)
[PATCH 5/9] delkin_cb: add warm-plug support, Bartlomiej Zolnierkiewicz..., (Mon Jun 2, 4:23 pm)
[PATCH 4/9] delkin_cb: use struct ide_port_info, Bartlomiej Zolnierkiewicz..., (Mon Jun 2, 4:23 pm)
[PATCH 3/9] delkin_cb: set proper hwif->gendev.parent value, Bartlomiej Zolnierkiewicz..., (Mon Jun 2, 4:23 pm)
Re: [PATCH 3/9] delkin_cb: set proper hwif-&gt;gendev.parent..., Sergei Shtylyov, (Wed Jun 4, 5:41 am)
[PATCH 2/9] ide: set hwif-&gt;dev in ide_init_port_hw(), Bartlomiej Zolnierkiewicz..., (Mon Jun 2, 4:23 pm)