login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
June
»
2
Re: [PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Yasunori Goto <y-goto@...>
To: Johannes Weiner <hannes@...>
Cc: Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>, Yinghai Lu <yhlu.kernel@...>, Andi Kleen <andi@...>, <linux-kernel@...>, <linux-mm@...>
Subject:
Re: [PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core
Date: Monday, June 2, 2008 - 10:48 am
> Hi,
quoted text
> > Yasunori Goto <y-goto@jp.fujitsu.com> writes: > > > Hello. > > > >> + /* > >> + * Reserve the area now: > >> + */ > >> + for (i = PFN_DOWN(new_start) + merge; i < PFN_UP(new_end); i++) > >> + if (test_and_set_bit(i, bdata->node_bootmem_map)) > >> + BUG(); > >> + > >> + region = phys_to_virt(bdata->node_boot_start + new_start); > >> + memset(region, 0, size); > >> + return region; > > > > bdata->last_success doesn't seem to be updated in alloc_bootmem_core(), > > it is updated in only __free(). > > Is it intended? If not, it should be updated, I suppose.... > > Yeah, I forgot that. See my reply to `bootmem: respect goal more > likely'. > > Thanks for reviewing! > > Hannes
Oh, I didn't notice it. Ok. I'll test newer version on my ia64 box. Bye. -- Yasunori Goto --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core
, Johannes Weiner
, (Fri May 30, 3:42 pm)
Re: [PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core
, Yasunori Goto
, (Mon Jun 2, 8:34 am)
Re: [PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core
, Johannes Weiner
, (Mon Jun 2, 9:57 am)
Re: [PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core
, Yasunori Goto
, (Mon Jun 2, 10:48 am)
Re: [PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core
, Johannes Weiner
, (Fri May 30, 6:11 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ingo Molnar
[patch 02/13] syslets: add syslet.h include file, user API/ABI definitions
Heiko Carstens
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24
Greg Kroah-Hartman
[PATCH 010/196] Chinese: add translation of Codingstyle
Rafael J. Wysocki
[Bug #10629] 2.6.26-rc1-$sha1: RIP __d_lookup+0x8c/0x160
git
:
linux-netdev
:
Gerrit Renker
[PATCH 0/37] dccp: Feature negotiation - last call for comments
Linus Torvalds
Re: [GIT]: Networking
Mark Lord
Re: [BUG] New Kernel Bugs
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
1 user
and
762 guests
online.
Online users
strcmp
Syndicate