Re: [PATCH] ata: ahci: power off unused ports

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jeff Garzik <jeff@...>
Cc: Pavel Machek <pavel@...>, Kristen Carlson Accardi <kristen.c.accardi@...>, Theodore Tso <tytso@...>, <linux-ide@...>, <linux-kernel@...>
Date: Monday, June 2, 2008 - 9:54 am

> > We don't need it per port Jeff, you are being quite silly here. Right now

Thats a simple question of what "=0" means - is it "disable=1" or
"enable=1" or to quote Alice in Wonderland

	'When I use a word,' Humpty Dumpty said, in a rather scornful
	tone,' it means just what I choose it to mean, neither more nor
	less

It really doesn't matter if it is on by default or off by default,
whether 0 means off or on, what matters is that the single switch is
quite sufficient initially to improve matters for everyone wanting to use
the feature without harming anyone else.

Sure you might want to make it per port later but someone who wants to
optimise that peculiar case, has a problem and can test it can deal with
that.

Alan

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Thu May 8, 7:10 pm)
Re: [PATCH] ata: ahci: power off unused ports, Theodore Tso, (Mon May 26, 11:08 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Tue May 27, 5:32 pm)
Re: [PATCH] ata: ahci: power off unused ports, Theodore Tso, (Tue May 27, 6:59 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Tue May 27, 7:32 pm)
Re: [PATCH] ata: ahci: power off unused ports, Pavel Machek, (Sat May 31, 4:00 am)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Sun Jun 1, 3:16 pm)
Re: [PATCH] ata: ahci: power off unused ports, Alan Cox, (Mon Jun 2, 3:04 am)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 3:43 am)
Re: [PATCH] ata: ahci: power off unused ports, Mark Lord, (Mon Jun 2, 9:03 am)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Mon Jun 2, 12:57 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 1:44 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 12:07 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Mon Jun 2, 1:00 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 1:45 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Mon Jun 2, 1:47 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 2:15 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Mon Jun 2, 2:16 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 2:38 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Tue Jun 3, 12:49 pm)
Re: [PATCH] ata: ahci: power off unused ports, Ric Wheeler, (Mon Jun 2, 2:30 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 2:40 pm)
Re: [PATCH] ata: ahci: power off unused ports, Matthew Garrett, (Mon Jun 2, 4:00 pm)
Re: [PATCH] ata: ahci: power off unused ports, Ric Wheeler, (Mon Jun 2, 2:49 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 2:52 pm)
Re: [PATCH] ata: ahci: power off unused ports, Greg Freemyer, (Mon Jun 2, 1:07 pm)
Re: [PATCH] ata: ahci: power off unused ports, Alan Cox, (Mon Jun 2, 4:22 am)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 5:48 am)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Mon Jun 2, 12:55 pm)
Re: [PATCH] ata: ahci: power off unused ports, Alan Cox, (Mon Jun 2, 9:54 am)
Re: [PATCH] ata: ahci: power off unused ports, Mark Lord, (Fri May 9, 11:06 am)
Re: [PATCH] ata: ahci: power off unused ports, Matthew Garrett, (Thu May 8, 7:37 pm)
Re: [PATCH] ata: ahci: power off unused ports, Lennart Sorensen, (Fri May 9, 11:58 am)
Re: [PATCH] ata: ahci: power off unused ports, Matthew Garrett, (Fri May 9, 12:06 pm)
Re: [PATCH] ata: ahci: power off unused ports, Lennart Sorensen, (Fri May 9, 12:14 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Fri May 9, 1:14 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Thu May 8, 7:35 pm)
Re: [PATCH] ata: ahci: power off unused ports, Matthew Garrett, (Thu May 8, 8:14 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Thu May 8, 8:28 pm)