Re: [PATCH 08 of 12] xen-console: add save/restore

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jeremy Fitzhardinge <jeremy@...>
Cc: LKML <linux-kernel@...>, xen-devel <xen-devel@...>, Thomas Gleixner <tglx@...>, Rafael J. Wysocki <rjw@...>
Date: Monday, June 2, 2008 - 7:17 am

-tip testing found the following xen-console symbols trouble:

 ERROR: "console_drivers" [drivers/video/xen-fbfront.ko] undefined!
 ERROR: "get_phys_to_machine" [drivers/video/xen-fbfront.ko] undefined!
 ERROR: "get_phys_to_machine" [drivers/net/xen-netfront.ko] undefined!
 ERROR: "get_phys_to_machine" [drivers/input/xen-kbdfront.ko] undefined!

with:

  http://redhat.com/~mingo/misc/config-Mon_Jun__2_12_26_38_CEST_2008.bad

get_phys_to_machine can indeed be exported but i'm less sure about the 
console_drivers export ... The temporary fix below resolves it for now.

	Ingo

------------->
Subject: xen: build fixes
From: Ingo Molnar <mingo@elte.hu>
Date: Mon Jun 02 13:13:04 CEST 2008

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/xen/mmu.c |    1 +
 kernel/printk.c    |    2 ++
 2 files changed, 3 insertions(+)

Index: linux/arch/x86/xen/mmu.c
===================================================================
--- linux.orig/arch/x86/xen/mmu.c
+++ linux/arch/x86/xen/mmu.c
@@ -136,6 +136,7 @@ unsigned long get_phys_to_machine(unsign
 	idx = p2m_index(pfn);
 	return p2m_top[topidx][idx];
 }
+EXPORT_SYMBOL_GPL(get_phys_to_machine);
 
 static void alloc_p2m(unsigned long **pp, unsigned long *mfnp)
 {
Index: linux/kernel/printk.c
===================================================================
--- linux.orig/kernel/printk.c
+++ linux/kernel/printk.c
@@ -76,6 +76,8 @@ EXPORT_SYMBOL(oops_in_progress);
 static DECLARE_MUTEX(console_sem);
 static DECLARE_MUTEX(secondary_console_sem);
 struct console *console_drivers;
+EXPORT_SYMBOL_GPL(console_drivers);
+
 /*
  * This is used for debugging the mess that is the VT code by
  * keeping track if we have the console semaphore held. It's
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00 of 12] xen: add save/restore/migrate for Xen domains, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
[PATCH 10 of 12] xen: implement save/restore, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
Re: [Xen-devel] [PATCH 10 of 12] xen: implement save/restore, Jeremy Fitzhardinge, (Mon Jun 2, 6:03 am)
Re: [Xen-devel] [PATCH 10 of 12] xen: implement save/restore, Jeremy Fitzhardinge, (Mon Jun 2, 6:52 am)
Re: [PATCH 10 of 12] xen: implement save/restore, Ingo Molnar, (Thu May 29, 3:31 am)
[PATCH] xen: fix compilation when CONFIG_PM_SLEEP is disabled, Jeremy Fitzhardinge, (Thu May 29, 4:02 am)
Re: [PATCH 10 of 12] xen: implement save/restore, Jeremy Fitzhardinge, (Thu May 29, 4:00 am)
[PATCH 12 of 12] hrtimer: remove warning in hres_timers_resume, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
[PATCH 08 of 12] xen-console: add save/restore, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
Re: [PATCH 08 of 12] xen-console: add save/restore, Ingo Molnar, (Mon Jun 2, 7:17 am)
Re: [PATCH 08 of 12] xen-console: add save/restore, Jeremy Fitzhardinge, (Mon Jun 2, 7:50 am)
Re: [PATCH 08 of 12] xen-console: add save/restore, Ingo Molnar, (Mon Jun 2, 7:18 am)
[PATCH 07 of 12] xen: fix unbind_from_irq(), Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
[PATCH 11 of 12] xen: maintain clock offset over save/restore, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
[PATCH 09 of 12] xenbus: rebind irq on restore, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
[PATCH 05 of 12] xen: add p2m mfn_list_list, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
Re: [bisected] Re: [PATCH 05 of 12] xen: add p2m mfn_list_list, Jeremy Fitzhardinge, (Fri May 30, 4:04 am)
Re: [bisected] Re: [PATCH 05 of 12] xen: add p2m mfn_list_list, Jeremy Fitzhardinge, (Wed May 28, 10:02 am)
Re: [bisected] Re: [PATCH 05 of 12] xen: add p2m mfn_list_list, Jeremy Fitzhardinge, (Mon Jun 2, 9:12 am)
[PATCH 03 of 12] xen: efficiently support a holey p2m table, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
[PATCH 06 of 12] xen: add rebind_evtchn_irq, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
[PATCH 04 of 12] xen: make dummy_shared_info non-static, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
[PATCH 02 of 12] xen: add configurable max domain size, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)
[PATCH 01 of 12] xen: make phys_to_machine structure dynamic, Jeremy Fitzhardinge, (Fri May 23, 9:41 am)