login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
June
»
2
Re: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM instead of __GFP_NORETRY
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Ingo Molnar <mingo@...>
To: Miquel van Smoorenburg <mikevs@...>
Cc: Andi Kleen <andi@...>, Andrew Morton <akpm@...>, Glauber Costa <gcosta@...>, <linux-kernel@...>, <linux-mm@...>
Subject:
Re: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM instead of __GFP_NORETRY
Date: Monday, June 2, 2008 - 6:15 am
* Miquel van Smoorenburg <mikevs@xs4all.net> wrote:
quoted text
> Okay, so how about this then ? > > --- linux-2.6.26-rc4.orig/arch/x86/kernel/pci-dma.c 2008-05-26 20:08:11.000000000 +0200 > +++ linux-2.6.26-rc4/arch/x86/kernel/pci-dma.c 2008-05-28 10:27:41.000000000 +0200 > @@ -397,9 +397,6 @@ > if (dev->dma_mask == NULL) > return NULL; > > - /* Don't invoke OOM killer */ > - gfp |= __GFP_NORETRY; > - > #ifdef CONFIG_X86_64 > /* Why <=? Even when the mask is smaller than 4GB it is often > larger than 16MB and in this case we have a chance of > @@ -410,7 +407,9 @@ > #endif > > again: > - page = dma_alloc_pages(dev, gfp, get_order(size)); > + /* Don't invoke OOM killer or retry in lower 16MB DMA zone */ > + page = dma_alloc_pages(dev, > + (gfp & GFP_DMA) ? gfp | __GFP_NORETRY : gfp, get_order(size)); > if (page == NULL) > return NULL;
applied to tip/pci-for-jesse for more testing. Thanks, Ingo --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM instead ...
, Miquel van Smoorenburg
, (Mon May 26, 7:49 pm)
Re: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM inst...
, Andrew Morton
, (Tue May 27, 4:47 am)
Re: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM inst...
, Andi Kleen
, (Tue May 27, 10:47 pm)
Re: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM inst...
, Miquel van Smoorenburg
, (Wed May 28, 4:31 am)
Re: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM inst...
, Ingo Molnar
, (Mon Jun 2, 6:15 am)
Re: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM inst...
, Andrew Morton
, (Wed May 28, 4:40 am)
Re: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM inst...
, Andi Kleen
, (Wed May 28, 8:54 am)
Re: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM inst...
, Miquel van Smoorenburg
, (Tue May 27, 5:35 am)
Re: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM inst...
, Ingo Molnar
, (Tue May 27, 4:03 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
KAMEZAWA Hiroyuki
Re: 2.6.23-mm1
Greg Kroah-Hartman
[PATCH 005/196] Chinese: add translation of SubmittingDrivers
David Miller
Re: Slow DOWN, please!!!
git
:
linux-netdev
:
Gerrit Renker
[PATCH 03/37] dccp: List management for new feature negotiation
David Miller
[GIT]: Networking
David Miller
Re: [BUG] New Kernel Bugs
Paweł Staszewski
rib_trie / Fix inflate_threshold_root. Now=15 size=11 bits
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
0 users
and
527 guests
online.
Syndicate