Home » Mailing list archives » linux-kernel » 2008 » June » 19

[patch 13/15] nf_conntrack_h323: fix memory leak in module initialization error path

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Greg KH <gregkh@...>
To: <linux-kernel@...>, <stable@...>
Cc: Justin Forbes <jmforbes@...>, Zwane Mwaikambo <zwane@...>, Theodore Ts'o <tytso@...>, Randy Dunlap <rdunlap@...>, Dave Jones <davej@...>, Chuck Wolber <chuckw@...>, Chris Wedgwood <reviews@...>, Michael Krufky <mkrufky@...>, Chuck Ebbert <cebbert@...>, Domenico Andreoli <cavokz@...>, Willy Tarreau <w@...>, Rodrigo Rubira Branco <rbranco@...>, <torvalds@...>, <akpm@...>, <alan@...>, <netfilter-devel@...>, Patrick McHardy <kaber@...>, <davem@...>
Subject: [patch 13/15] nf_conntrack_h323: fix memory leak in module initialization error path
Date: Thursday, June 19, 2008 - 5:30 pm

2.6.25-stable review patch.  If anyone has any objections, please let us
know.

------------------
From: Patrick McHardy <kaber@trash.net>

netfilter: nf_conntrack_h323: fix memory leak in module initialization error path

Upstream commit 8a548868db62422113104ebc658065e3fe976951

Properly free h323_buffer when helper registration fails.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 net/netfilter/nf_conntrack_h323_main.c |    1 +
 1 file changed, 1 insertion(+)

--- a/net/netfilter/nf_conntrack_h323_main.c
+++ b/net/netfilter/nf_conntrack_h323_main.c
@@ -1799,6 +1799,7 @@ err3:
 err2:
 	nf_conntrack_helper_unregister(&nf_conntrack_helper_h245);
 err1:
+	kfree(h323_buffer);
 	return ret;
 }
 

-- 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[00/15] 2.6.25-stable review, Greg KH, (Thu Jun 19, 5:26 pm)
[patch 15/15] x86: disable mwait for AMD family 10H/11H CPUs, Greg KH, (Thu Jun 19, 5:30 pm)
[patch 14/15] x86: remove mwait capability C-state check, Greg KH, (Thu Jun 19, 5:30 pm)
[patch 13/15] nf_conntrack_h323: fix memory leak in module i..., Greg KH, (Thu Jun 19, 5:30 pm)
[patch 12/15] nf_conntrack_h323: fix module unload crash, Greg KH, (Thu Jun 19, 5:30 pm)
[patch 11/15] nf_conntrack: fix ctnetlink related crash in n..., Greg KH, (Thu Jun 19, 5:30 pm)
[patch 10/15] SCSI: sr: fix corrupt CD data after media chan..., Greg KH, (Thu Jun 19, 5:30 pm)
[patch 09/15] ACPICA: Ignore ACPI table signature for Load()..., Greg KH, (Thu Jun 19, 5:30 pm)
Re: [patch 09/15] ACPICA: Ignore ACPI table signature for Lo..., , (Fri Jun 27, 6:14 am)
[patch 08/15] scsi_host regression: fix scsi host leak, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 07/15] b43: Fix possible NULL pointer dereference in ..., Greg KH, (Thu Jun 19, 5:29 pm)
[patch 06/15] b43: Fix noise calculation WARN_ON, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 05/15] virtio_net: Fix skb-&gt;csum_start computation, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 04/15] opti621: remove DMA support, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 03/15] opti621: disable read prefetch, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 02/15] Fix tty speed handling on 8250, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 01/15] x86-64: Fix "bytes left to copy" return value ..., Greg KH, (Thu Jun 19, 5:29 pm)