Home » Mailing list archives » linux-kernel » 2008 » June » 19

[patch 09/15] ACPICA: Ignore ACPI table signature for Load() operator

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Greg KH <gregkh@...>
To: <linux-kernel@...>, <stable@...>
Cc: Justin Forbes <jmforbes@...>, Zwane Mwaikambo <zwane@...>, Theodore Ts'o <tytso@...>, Randy Dunlap <rdunlap@...>, Dave Jones <davej@...>, Chuck Wolber <chuckw@...>, Chris Wedgwood <reviews@...>, Michael Krufky <mkrufky@...>, Chuck Ebbert <cebbert@...>, Domenico Andreoli <cavokz@...>, Willy Tarreau <w@...>, Rodrigo Rubira Branco <rbranco@...>, <torvalds@...>, <akpm@...>, <alan@...>, <linux-acpi@...>, Bob Moore <robert.moore@...>, Lin Ming <ming.m.lin@...>, Len Brown <len.brown@...>
Subject: [patch 09/15] ACPICA: Ignore ACPI table signature for Load() operator
Date: Thursday, June 19, 2008 - 5:30 pm

2.6.25-stable review patch.  If anyone has any objections, please let us
know.

------------------
From: Bob Moore <robert.moore@intel.com>

upstream bc45b1d39a925b56796bebf8a397a0491489d85c

Without this patch booting with acpi_osi="!Windows 2006" is required
for several machines to function properly with cpufreq
due to failure to load a Vista specific table with a bad signature.

Only "SSDT" is acceptable to the ACPI spec, but tables are
seen with OEMx and null sigs. Therefore, signature validation
is worthless.  Apparently MS ACPI accepts such signatures, ACPICA
must be compatible.

http://bugzilla.kernel.org/show_bug.cgi?id=9919
http://bugzilla.kernel.org/show_bug.cgi?id=10383
http://bugzilla.kernel.org/show_bug.cgi?id=10454
https://bugzilla.novell.com/show_bug.cgi?id=396311

Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/acpi/tables/tbinstal.c |   18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

--- a/drivers/acpi/tables/tbinstal.c
+++ b/drivers/acpi/tables/tbinstal.c
@@ -123,17 +123,13 @@ acpi_tb_add_table(struct acpi_table_desc
 		}
 	}
 
-	/* The table must be either an SSDT or a PSDT or an OEMx */
-
-	if ((!ACPI_COMPARE_NAME(table_desc->pointer->signature, ACPI_SIG_PSDT))
-	    &&
-	    (!ACPI_COMPARE_NAME(table_desc->pointer->signature, ACPI_SIG_SSDT))
-	    && (strncmp(table_desc->pointer->signature, "OEM", 3))) {
-		ACPI_ERROR((AE_INFO,
-			    "Table has invalid signature [%4.4s], must be SSDT, PSDT or OEMx",
-			    table_desc->pointer->signature));
-		return_ACPI_STATUS(AE_BAD_SIGNATURE);
-	}
+	/*
+	 * Originally, we checked the table signature for "SSDT" or "PSDT" here.
+	 * Next, we added support for OEMx tables, signature "OEM".
+	 * Valid tables were encountered with a null signature, so we've just
+	 * given up on validating the signature, since it seems to be a waste
+	 * of code. The original code was removed (05/2008).
+	 */
 
 	(void)acpi_ut_acquire_mutex(ACPI_MTX_TABLES);
 

-- 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[00/15] 2.6.25-stable review, Greg KH, (Thu Jun 19, 5:26 pm)
[patch 15/15] x86: disable mwait for AMD family 10H/11H CPUs, Greg KH, (Thu Jun 19, 5:30 pm)
[patch 14/15] x86: remove mwait capability C-state check, Greg KH, (Thu Jun 19, 5:30 pm)
[patch 13/15] nf_conntrack_h323: fix memory leak in module i..., Greg KH, (Thu Jun 19, 5:30 pm)
[patch 12/15] nf_conntrack_h323: fix module unload crash, Greg KH, (Thu Jun 19, 5:30 pm)
[patch 11/15] nf_conntrack: fix ctnetlink related crash in n..., Greg KH, (Thu Jun 19, 5:30 pm)
[patch 10/15] SCSI: sr: fix corrupt CD data after media chan..., Greg KH, (Thu Jun 19, 5:30 pm)
[patch 09/15] ACPICA: Ignore ACPI table signature for Load()..., Greg KH, (Thu Jun 19, 5:30 pm)
Re: [patch 09/15] ACPICA: Ignore ACPI table signature for Lo..., , (Fri Jun 27, 6:14 am)
[patch 08/15] scsi_host regression: fix scsi host leak, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 07/15] b43: Fix possible NULL pointer dereference in ..., Greg KH, (Thu Jun 19, 5:29 pm)
[patch 06/15] b43: Fix noise calculation WARN_ON, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 05/15] virtio_net: Fix skb-&gt;csum_start computation, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 04/15] opti621: remove DMA support, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 03/15] opti621: disable read prefetch, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 02/15] Fix tty speed handling on 8250, Greg KH, (Thu Jun 19, 5:29 pm)
[patch 01/15] x86-64: Fix "bytes left to copy" return value ..., Greg KH, (Thu Jun 19, 5:29 pm)