[PATCH] Add support for IRQ_NOAUTOEN in __set_irq_handler

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Date: Thursday, June 19, 2008 - 3:37 pm

Any reason for __set_irq_handler not supporting the IRQ_NOAUTOEN flag?

/Esben

 kernel/irq/chip.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 964964b..42bb163 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -584,10 +584,15 @@ __set_irq_handler(unsigned int irq,
irq_flow_handler_t handle, int is_chained,
 	desc->name = name;

 	if (handle != handle_bad_irq && is_chained) {
-		desc->status &= ~IRQ_DISABLED;
 		desc->status |= IRQ_NOREQUEST | IRQ_NOPROBE;
-		desc->depth = 0;
-		desc->chip->unmask(irq);
+		if (!(desc->status & IRQ_NOAUTOEN)) {
+			desc->depth = 0;
+			desc->status &= ~IRQ_DISABLED;
+			desc->chip->unmask(irq);
+		} else {
+			/* Undo nested disables: */
+			desc->depth = 1;
+		}
 	}
 	spin_unlock_irqrestore(&desc->lock, flags);
 }

-- 
Esben Haabendal, Senior Software Consultant
DoréDevelopment ApS, Ved Stranden 1, 9560 Hadsund, DK-Denmark
Tlf: +45 51 92 53 93, mail: eha@doredevelopment.dk
WWW: http://www.doredevelopment.dk
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Add support for IRQ_NOAUTOEN in __set_irq_handler, Esben Haabendal, (Thu Jun 19, 3:37 pm)