Re: [E1000-devel] [TCP]: TCP_DEFER_ACCEPT causes leak sockets

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Kok, Auke <auke-jan.h.kok@...>
Cc: David Miller <davem@...>, <vgusev@...>, <e1000-devel@...>, <netdev@...>, <linux-kernel@...>, <rjw@...>, <mcmanus@...>, <ilpo.jarvinen@...>, <kuznet@...>, <xemul@...>, Linus Torvalds <torvalds@...>
Date: Wednesday, June 18, 2008 - 5:32 pm

* Ingo Molnar <mingo@elte.hu> wrote:


ok, i tried it now, and there's good news: the latency problem seems 
largely fixed by e1000e. (yay!)

with e1000 i got these anomalous latencies:

 64 bytes from europe (10.0.1.15): icmp_seq=10 ttl=64 time=1000 ms
 64 bytes from europe (10.0.1.15): icmp_seq=11 ttl=64 time=0.882 ms
 64 bytes from europe (10.0.1.15): icmp_seq=12 ttl=64 time=1007 ms
 64 bytes from europe (10.0.1.15): icmp_seq=13 ttl=64 time=0.522 ms
 64 bytes from europe (10.0.1.15): icmp_seq=14 ttl=64 time=1003 ms
 64 bytes from europe (10.0.1.15): icmp_seq=15 ttl=64 time=0.381 ms
 64 bytes from europe (10.0.1.15): icmp_seq=16 ttl=64 time=1010 ms

with e1000e i get:

 64 bytes from europe (10.0.1.15): icmp_seq=1 ttl=64 time=0.212 ms
 64 bytes from europe (10.0.1.15): icmp_seq=2 ttl=64 time=0.372 ms
 64 bytes from europe (10.0.1.15): icmp_seq=3 ttl=64 time=0.815 ms
 64 bytes from europe (10.0.1.15): icmp_seq=4 ttl=64 time=0.961 ms
 64 bytes from europe (10.0.1.15): icmp_seq=5 ttl=64 time=0.201 ms
 64 bytes from europe (10.0.1.15): icmp_seq=6 ttl=64 time=0.788 ms

TCP latencies are fine too - ssh feels snappy again.

it still does not have nearly as good latencies as say forcedeth though:

 64 bytes from mercury (10.0.1.13): icmp_seq=1 ttl=64 time=0.076 ms
 64 bytes from mercury (10.0.1.13): icmp_seq=2 ttl=64 time=0.085 ms
 64 bytes from mercury (10.0.1.13): icmp_seq=3 ttl=64 time=0.045 ms
 64 bytes from mercury (10.0.1.13): icmp_seq=4 ttl=64 time=0.053 ms

that's 10 times better packet latencies.

and even an ancient Realtek RTL-8139 over 10 megabit Ethernet (!) has 
better latencies than the e1000e over 1000 megabit:

 64 bytes from pluto (10.0.1.10): icmp_seq=2 ttl=64 time=0.309 ms
 64 bytes from pluto (10.0.1.10): icmp_seq=3 ttl=64 time=0.333 ms
 64 bytes from pluto (10.0.1.10): icmp_seq=4 ttl=64 time=0.329 ms
 64 bytes from pluto (10.0.1.10): icmp_seq=5 ttl=64 time=0.311 ms
 64 bytes from pluto (10.0.1.10): icmp_seq=6 ttl=64 time=0.302 ms

is it done intentionally perhaps? I dont think it makes much sense to 
delay rx/tx processing on a completely idle box for such a long time.

The options i used are:

 CONFIG_E1000=y
 CONFIG_E1000_NAPI=y
 # CONFIG_E1000_DISABLE_PACKET_SPLIT is not set
 CONFIG_E1000E=y
 CONFIG_E1000E_ENABLED=y


one possibility would be to change 'make oldconfig' to keep old options 
around - as long as they look "unknown" to a particular kernel. It would 
list them in some special "unknown options" section near the end of the 
.config or so. That way the E1000E=y setting could survive a bisection 
run which dives down into older kernel versions. (obviously old kernels 
wont grow this capability magically, so if we do such a change we'll 
have to wait years for it all to trickle through.)

and eventually E1000E could become the default.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Wed Jun 11, 7:52 pm)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Thu Jun 12, 7:32 pm)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Fri Jun 13, 2:30 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Fri Jun 13, 5:32 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Fri Jun 13, 7:09 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Fri Jun 13, 7:47 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Mon Jun 16, 7:59 pm)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Tue Jun 17, 3:26 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Tue Jun 17, 3:38 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Tue Jun 17, 4:09 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Vitaliy Gusev, (Tue Jun 17, 4:43 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Tue Jun 17, 4:32 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Tue Jun 17, 5:08 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Tue Jun 17, 5:27 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Tue Jun 17, 5:29 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Tue Jun 17, 5:39 am)
Re: [E1000-devel] [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Wed Jun 18, 5:32 pm)
Re: [E1000-devel] [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Denys Fedoryshchenko, (Wed Jun 18, 5:41 pm)
Re: [E1000-devel] [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Denys Fedoryshchenko, (Wed Jun 18, 6:44 pm)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Jarek Poplawski, (Thu Jun 19, 3:06 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Fri Jun 13, 5:10 pm)