Re: [E1000-devel] [TCP]: TCP_DEFER_ACCEPT causes leak sockets

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Wednesday, June 18, 2008 - 1:08 pm

* Kok, Auke <auke-jan.h.kok@intel.com> wrote:


will try it.

But even it if solves the problem it's a nasty complication: given how 
many times i have to bisect back into the times when there was only 
e1000 around, how do i handle the transition? I have automated bisection 
tools, etc. and i bisect very frequently.

It's a real practical problem for me: if i have E1000E=y in my .config 
and go back to an older kernel, i lose that .config setting in 'make 
oldconfig'. Then when the bisection run happens to go back into the 
E1000E times, 'make oldconfig' picks up E1000E with a default-off 
setting - and things break or work differently.

no other Linux driver i'm using forces me to do that and i rely on many 
of them and i rely on proper 'make oldconfig' behavior on a daily basis. 
Until now i was able to do automatic bisection back for _years_, to the 
v2.6.19 times. You broke that.

And that's just one driver out of thousands of Linux drivers. Imagine 
what happened to bisectability and migration quality if every driver 
version update was this careless about its installed base as 
e1000/e1000e.

The e1000 -> e1000e migration it was not only done in an incompetent, 
amateurish way, you also ignored real feedback and that combined 
together is totally lame and inacceptable behavior in my book. You 
should not expect praise and roses from me as long as you do stupid 
things like that.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Wed Jun 11, 4:52 pm)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Thu Jun 12, 4:32 pm)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Thu Jun 12, 11:30 pm)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Fri Jun 13, 2:32 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Fri Jun 13, 4:09 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Fri Jun 13, 4:47 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Fri Jun 13, 2:10 pm)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Mon Jun 16, 4:59 pm)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Tue Jun 17, 12:26 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Tue Jun 17, 12:38 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Tue Jun 17, 1:09 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Tue Jun 17, 1:32 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Vitaliy Gusev, (Tue Jun 17, 1:43 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Tue Jun 17, 2:08 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Tue Jun 17, 2:27 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, David Miller, (Tue Jun 17, 2:29 am)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Tue Jun 17, 2:39 am)
Re: [E1000-devel] [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Ingo Molnar, (Wed Jun 18, 1:08 pm)
Re: [E1000-devel] [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Denys Fedoryshchenko, (Wed Jun 18, 2:41 pm)
Re: [E1000-devel] [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Denys Fedoryshchenko, (Wed Jun 18, 3:44 pm)
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets, Jarek Poplawski, (Thu Jun 19, 12:06 am)