Home » Mailing list archives » linux-kernel » 2008 » June » 18

Re: [patch] aio: invalidate async directio writes

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christoph Hellwig <hch@...>
To: Jeff Moyer <jmoyer@...>
Cc: Christoph Hellwig <hch@...>, <akpm@...>, <zach.brown@...>, <linux-aio@...>, <linux-kernel@...>
Subject: Re: [patch] aio: invalidate async directio writes
Date: Wednesday, June 18, 2008 - 3:48 pm

On Wed, Jun 18, 2008 at 03:45:28PM -0400, Jeff Moyer wrote:

With your patch we complete aio dio write request in user context, which
is great for filesystems that need to do more complex activity in the
completion handler, e.g. XFS for the unwritten extent conversion.  But
only doing this for the write case is only very partially useful, we
should be doing this for the read case, too.

See fs/xfs/linux-2.6/xfs_aops.c:xfs_end_io_direct() for what I mean.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] aio: invalidate async directio writes, Jeff Moyer, (Wed Jun 18, 2:09 pm)
Re: [patch] aio: invalidate async directio writes, Zach Brown, (Thu Jun 19, 1:23 pm)
Re: [patch] aio: invalidate async directio writes, Peter Zijlstra, (Thu Jun 19, 3:51 am)
Re: [patch] aio: invalidate async directio writes, Zach Brown, (Thu Jun 19, 1:50 pm)
Re: [patch] aio: invalidate async directio writes, Jeff Moyer, (Thu Jun 19, 9:50 am)
Re: [patch] aio: invalidate async directio writes, Peter Zijlstra, (Thu Jun 19, 9:58 am)
Re: [patch] aio: invalidate async directio writes, Jeff Moyer, (Thu Jun 19, 10:05 am)
Re: [patch] aio: invalidate async directio writes, Christoph Hellwig, (Wed Jun 18, 2:22 pm)
Re: [patch] aio: invalidate async directio writes, Jeff Moyer, (Wed Jun 18, 3:45 pm)
Re: [patch] aio: invalidate async directio writes, Christoph Hellwig, (Wed Jun 18, 3:48 pm)