Home » Mailing list archives » linux-kernel » 2008 » June » 18

Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg_constant

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Stefan Richter <stefanr@...>
To: Paolo Ciarrocchi <paolo.ciarrocchi@...>
Cc: Dmitri Vorobiev <dmitri.vorobiev@...>, Ingo Molnar <mingo@...>, tglx <tglx@...>, hpa <hpa@...>, Linux Kernel <linux-kernel@...>, Andy Whitcroft <apw@...>
Subject: Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg_constant
Date: Wednesday, June 18, 2008 - 10:56 am

> On Wed, Jun 18, 2008 at 3:09 PM, Dmitri Vorobiev

It should obviously be

 static void fld_const(const FPU_REG *c, int adj, u_char tag)

FPU_REG is not an appropriate type name though.  Is "typedef struct
fpu__reg FPU_REG;" necessary at all?  (Removing it would create some
code churn all over x86/math-emu/ though. Maybe not desirable.)
-- 
Stefan Richter
-=====-==--- -==- =--=-
http://arcgraph.de/sr/
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] x86: coding style fixes to arch/x86/math-emu/reg_con..., Paolo Ciarrocchi, (Sat Jun 14, 2:44 pm)
Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg..., Dmitri Vorobiev, (Wed Jun 18, 9:09 am)
Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg..., Paolo Ciarrocchi, (Wed Jun 18, 10:19 am)
Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg..., Andy Whitcroft, (Thu Jun 19, 5:07 am)
Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg..., Dmitri Vorobiev, (Thu Jun 19, 5:19 am)
Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg..., Stefan Richter, (Wed Jun 18, 10:56 am)
Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg..., Ingo Molnar, (Wed Jun 18, 9:01 am)